Uh oh!
There was an error while loading. Please reload this page.
Allow to retrieve the quota itself via the provisioning api - #890
Conversation
mention-bot
commented
Aug 16, 2016
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @tomneedham and @rullzer to be potential reviewers |
Nice! @nickvergessen One small issue: server/lib/public/Files/FileInfo.php Line 56 in e321ecd 👍 for the backport since then we won't have to implement a feature detection on Android and people would just have to upgrade e.g. to 9.0.54 (or something like that). Else we would have to restrict quotas being displayed to Nc 11... |
nickvergessen
commented
Aug 16, 2016
Fixed the comment. Btw one more thing, the endpoint is from the Provisioning API App, it is shipped and enabled by default, but it can be disabled. Just to be sure that you know this and have a fallback/error handling for the missing endpoint. |
AndyScherzinger
commented
Aug 16, 2016
Uuuh, thanks for that comment 👍 Will check our code for that matter cc @tobiasKaminsky |
nickvergessen
commented
Aug 17, 2016
@MorrisJobke@LukasReschke would be nice to get this one liner into 10 before the release |
AndyScherzinger
commented
Aug 17, 2016
@MorrisJobke@LukasReschke That would be awesome! 👍 |
rullzer
commented
Aug 17, 2016
LGTM! |
36ba734 to
a9f3606Comparerullzer
commented
Aug 17, 2016
Rebased because of conflict |
LukasReschke
commented
Aug 17, 2016
LGTM |
nickvergessen
commented
Aug 17, 2016
Backport is in #896 |
…ited-via-api Allow to retrieve the quota itself via the provisioning api
Fix#879
@AndyScherzinger special values are
<0:server/lib/public/Files/FileInfo.php
Lines 45 to 59 in e321ecd
I guess it would be nice to backport this, and since the patch is very little, it should also be save to do so.