Skip to content

[stable12] Show EOL warning in the update section - #8987

Merged
rullzer merged 1 commit into
stable12from
backport/8821/show-eol-warning-12
Apr 18, 2018
Merged

[stable12] Show EOL warning in the update section#8987
rullzer merged 1 commit into
stable12from
backport/8821/show-eol-warning-12

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Backport #8986


$params = [
'isNewVersionAvailable' => !empty($updateState['updateAvailable']),
'isNewVersionAvailable' => true, //!empty($updateState['updateAvailable']),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 let me fix this

@MorrisJobke
MorrisJobkeforce-pushed the backport/8821/show-eol-warning-12 branch from 6737553 to 30626edCompareApril 12, 2018 09:56
@codecov

codecovBot commented Apr 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8987 into stable12 will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@ Coverage Diff @@## stable12 #8987 +/- ##
==============================================
- Coverage 53.91% 53.91% -0.01% - Complexity 22780 22782 +2 
==============================================
Files 1387 1387 Lines 87286 87295 +9 Branches 1331 1331 ==============================================
+ Hits 47063 47065 +2 - Misses 40223 40230 +7
Impacted FilesCoverage ΔComplexity Δ
apps/updatenotification/templates/admin.php0% <0%> (ø)0 <0> (ø)⬇️
lib/private/Updater/VersionCheck.php92.5% <100%> (+0.19%)8 <0> (+1)⬆️
...atenotification/lib/Controller/AdminController.php64.4% <100%> (+0.61%)12 <0> (+1)⬆️
apps/updatenotification/lib/UpdateChecker.php76.19% <100%> (+1.19%)9 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and fixed the typo. And works 👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the backport/8821/show-eol-warning-12 branch from 30626ed to 5f1f633CompareApril 18, 2018 11:50
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Rebased and fixed the last failing test

@MorrisJobkeMorrisJobke mentioned this pull request Apr 18, 2018
3 tasks
@rullzer
rullzer merged commit d39f00a into stable12Apr 18, 2018
@rullzer
rullzer deleted the backport/8821/show-eol-warning-12 branch April 18, 2018 19:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@MorrisJobke