Uh oh!
There was an error while loading. Please reload this page.
Fix webdav support for OneNote clients - #8996
Conversation
brandonkirsch
commented
Mar 26, 2018
Current version of One Note has User Agent string: OneNote/16.0.8431.2110 (Windows/6.1; Desktop WOW64; en-US; Desktop app; LENOVO/20AQ006HUS) |
rullzer
left a comment
There was a problem hiding this comment.
Pfff I hate this magic... but yeah fair enough 🙈
nickvergessen
commented
Mar 27, 2018
No microsoft anymore? |
brandonkirsch
commented
Mar 27, 2018
No, over the years they have removed "Microsoft", "Office" and the release year from User Agent. Thanks for reviewing the patch it will be easier for me to stay up to date. |
schiessle
left a comment
There was a problem hiding this comment.
no idea about OneNote, but it sounds reasonable
MorrisJobke
commented
Apr 3, 2018
@nickvergessen@rullzer@schiessle I guess we should backport this to stable13 at least, right? |
schiessle
commented
Apr 4, 2018
@MorrisJobke yes, I think it would make sense... @brandonkirsch do you want to create a PR for the backport angainst stable13? This would be awesome! |
nickvergessen
commented
Apr 9, 2018
yes |
MorrisJobke
commented
Apr 18, 2018
Backported in #9236 |
Microsoft OneNote WebDAV Client requires some special handling on the server side that is enabled by User Agent detection. This PR updates the User Agent detection string to be compatible with all versions of OneNote.