Skip to content

[stable13] Fix proper permissions for multiple file access - #9072

Merged
MorrisJobke merged 2 commits into
stable13from
backport/8891/fix_8890-13
Apr 4, 2018
Merged

[stable13] Fix proper permissions for multiple file access#9072
MorrisJobke merged 2 commits into
stable13from
backport/8891/fix_8890-13

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #8891

Fixes#8890
In case you have access to a file via multiple ways, for example:
1. the file is shared with you with permission read only
2. the folder containing the file is shared with your read/write
Requesting the getById function on the userFolder would give back two
entries but both with the same permissions. Depending on the node you
picked this is not right.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Apr 4, 2018
@rullzerrullzer added this to the Nextcloud 13.0.2 milestone Apr 4, 2018
@codecov

codecovBot commented Apr 4, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9072 into stable13 will not change coverage.
The diff coverage is 80%.

@@ Coverage Diff @@## stable13 #9072 +/- ##
===========================================
Coverage 51.33% 51.33% Complexity 25029 25029 ===========================================
Files 1609 1609 Lines 95305 95305 Branches 1376 1376 ===========================================
Hits 48924 48924 Misses 46381 46381
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Node/Folder.php88.78% <80%> (ø)50 <0> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit ba29fd1 into stable13Apr 4, 2018
@MorrisJobke
MorrisJobke deleted the backport/8891/fix_8890-13 branch April 4, 2018 11:59
@MorrisJobkeMorrisJobke mentioned this pull request Apr 18, 2018
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst