Skip to content

The integrationtests expect a string - #9136

Merged
MorrisJobke merged 2 commits into
masterfrom
bugfix/noid/fix_provisioning_integrationtests
Apr 11, 2018
Merged

The integrationtests expect a string#9136
MorrisJobke merged 2 commits into
masterfrom
bugfix/noid/fix_provisioning_integrationtests

Conversation

@rullzer

@rullzerrullzer commented Apr 10, 2018

Copy link
Copy Markdown
Member

@skjnldsv I guess we missed this during your improvements
@danxuliu maybe youknow of an easier fix for the integration tests.

@rullzer
The integrationtests expect a string
d363e2f
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Apr 10, 2018
@rullzerrullzer added this to the Nextcloud 14 milestone Apr 10, 2018
danxuliu
danxuliu approved these changes Apr 10, 2018
View reviewed changes

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Fix tests
a8d4b06
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Apr 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9136 into master will decrease coverage by 16.91%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9136 +/- ##
=============================================
- Coverage 51.84% 34.92% -16.92% 
Complexity 25313 25313 =============================================
Files 1604 1604 Lines 95133 95133 Branches 1387 1387 =============================================
- Hits 49324 33228 -16096 - Misses 45809 61905 +16096
Impacted FilesCoverage ΔComplexity Δ
apps/provisioning_api/lib/Controller/AUserData.php0% <0%> (-61.85%)14 <0> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php0% <0%> (-100%)8% <0%> (ø)
lib/private/Hooks/LegacyEmitter.php0% <0%> (-100%)1% <0%> (ø)
core/Command/Background/WebCron.php0% <0%> (-100%)1% <0%> (ø)
...ddleware/Security/Exceptions/NotAdminException.php0% <0%> (-100%)1% <0%> (ø)
lib/public/AppFramework/Http/JSONResponse.php0% <0%> (-100%)5% <0%> (ø)
apps/dav/lib/Files/Sharing/FilesDropPlugin.php0% <0%> (-100%)6% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php0% <0%> (-100%)8% <0%> (ø)
lib/private/BackgroundJob/QueuedJob.php0% <0%> (-100%)1% <0%> (ø)
settings/Activity/SecurityFilter.php0% <0%> (-100%)7% <0%> (ø)
... and 522 more

MorrisJobke
MorrisJobke approved these changes Apr 10, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 10, 2018
@MorrisJobke
MorrisJobke merged commit a655401 into masterApr 11, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/noid/fix_provisioning_integrationtests branch April 11, 2018 00:11
@skjnldsv

skjnldsv commented Apr 11, 2018

Copy link
Copy Markdown
Member

🙈

@skjnldsvskjnldsv mentioned this pull request Apr 12, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@danxuliudanxuliudanxuliu approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@skjnldsv@MorrisJobke@danxuliu