Skip to content

fix appinfo parsing when a single localized option is provided - #9159

Merged
MorrisJobke merged 1 commit into
masterfrom
appinfo-single-localized
Apr 17, 2018
Merged

fix appinfo parsing when a single localized option is provided#9159
MorrisJobke merged 1 commit into
masterfrom
appinfo-single-localized

Conversation

@icewind1991

@icewind1991icewind1991 commented Apr 12, 2018

Copy link
Copy Markdown
Member

See #8223

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Apr 12, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Apr 12, 2018
@icewind1991icewind1991 mentioned this pull request Apr 12, 2018
Closed
MorrisJobke
MorrisJobke approved these changes Apr 12, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke

MorrisJobke commented Apr 12, 2018

Copy link
Copy Markdown
Member

Fixes this issue:

{
"reqId": "pzYTbLf31SIos81QcAFn",
"level": 3,
"time": "2018-04-12T11:46:26+00:00",
"remoteAddr": "172.20.0.1",
"user": "admin",
"app": "PHP",
"method": "GET",
"url": "/index.php/settings/apps/list?category=updates",
"message": "Undefined index: @value at /var/www/html/lib/private/legacy/app.php#1019",
"userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1 Safari/605.1.15",
"version": "14.0.0.2"
}

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 17, 2018
@icewind1991@MorrisJobke
fix appinfo parsing when a single localized option is provided
46d0d0c
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
MorrisJobkeforce-pushed the appinfo-single-localized branch from af18c97 to 46d0d0cCompareApril 17, 2018 09:14
@MorrisJobke

MorrisJobke commented Apr 17, 2018

Copy link
Copy Markdown
Member

Rebased to trigger stuck CI.

@codecov

codecovBot commented Apr 17, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9159 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #9159 +/- ##
============================================
+ Coverage 51.9% 51.92% +0.02% - Complexity 25359 25360 +1 
============================================
Files 1606 1606 Lines 95310 95312 +2 Branches 1394 1394 ============================================
+ Hits 49470 49493 +23 + Misses 45840 45819 -21
Impacted FilesCoverage ΔComplexity Δ
lib/private/legacy/app.php62.63% <100%> (+3.76%)196 <0> (+1)⬆️
core/js/js.js65.88% <0%> (+0.55%)0% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit 42b7dfe into masterApr 17, 2018
@MorrisJobke
MorrisJobke deleted the appinfo-single-localized branch April 17, 2018 11:45
@nickvergessen

nickvergessen commented Apr 18, 2018

Copy link
Copy Markdown
Member

Should backport

This was referenced Apr 18, 2018
Merged
Merged
@MorrisJobke

MorrisJobke commented Apr 18, 2018

Copy link
Copy Markdown
Member

stable13 #9233

This was referenced Apr 18, 2018
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@MorrisJobke@nickvergessen@rullzer