Uh oh!
There was an error while loading. Please reload this page.
improve error reporting and move format parameter to the options - #9256
Merged
Conversation
schiessleforce-pushed
the
fed-sharing-improvements
branch
from
April 20, 2018 14:57
9af3025 to
dd3f0cbCompareCodecov Report
@@ Coverage Diff @@## master #9256 +/- ##
============================================
- Coverage 51.93% 31.5% -20.44% - Complexity 25389 25402 +13
============================================
Files 1608 1608 Lines 95436 95464 +28 Branches 1394 1394 ============================================
- Hits 49564 30074 -19490 - Misses 45872 65390 +19518
|
MorrisJobke
commented
Apr 24, 2018
Member
There is another one that resets the token: |
rullzer
reviewed
Apr 24, 2018
| $this->trustedServers->addSharedSecret($url, $sharedSecret); | ||
| // reset token after the exchange of the shared secret was successful | ||
| $this->dbHandler->addToken($url, ''); |
Member
There was a problem hiding this comment.
Because this is not needed to be reset. The code knows what is the bigger and what is the smaller token. It often confused people why one server deletes it. And also there is code wise no good reason why it should be read. On the other hand this could give insights into debugging sessions so we keep it just as it is.
MorrisJobke
approved these changes
Apr 24, 2018
MorrisJobkeforce-pushed
the
fed-sharing-improvements
branch
from
April 25, 2018 09:59
dd3f0cb to
178244aCompareMorrisJobke
commented
Apr 25, 2018
Member
I also fixed the tests 🙈 |
MorrisJobkeforce-pushed
the
fed-sharing-improvements
branch
from
April 25, 2018 10:03
178244a to
5110983CompareMorrisJobkeforce-pushed
the
fed-sharing-improvements
branch
from
April 25, 2018 11:50
5110983 to
5dfddceCompareSigned-off-by: Bjoern Schiessle <bjoern@schiessle.org>
MorrisJobkeforce-pushed
the
fed-sharing-improvements
branch
from
April 25, 2018 11:54
5dfddce to
0e0cfa0CompareMorrisJobke
commented
Apr 25, 2018
Member
I just noticed that the |
MorrisJobke
commented
May 9, 2018
Member
@schiessle What about the backport? 🏓 😉 |
MorrisJobke
commented
May 29, 2018
Member
Backport in #9657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make exchange of shared secret more robust and improve error reporting.