Skip to content

Fix DI for federated file sharing controller - #9269

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-DI-for-federeatedfilesharing-controller
Apr 23, 2018
Merged

Fix DI for federated file sharing controller#9269
MorrisJobke merged 1 commit into
masterfrom
fix-DI-for-federeatedfilesharing-controller

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Apr 23, 2018

Copy link
Copy Markdown
Member

For #9255

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Apr 23, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Apr 23, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Apr 23, 2018
Merged
nickvergessen
nickvergessen reviewed Apr 23, 2018
View reviewed changes
Comment threadapps/federatedfilesharing/tests/Controller/RequestHandlerControllerTest.php Outdated

$this->cloudIdManager = new CloudIdManager();

$this->logger = $this->getMockBuilder(ILogger::class)->getMock();

@nickvergessennickvergessenApr 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createMock for extra points

@MorrisJobkeMorrisJobkeApr 23, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want them! 💯

@MorrisJobke
MorrisJobkeforce-pushed the fix-DI-for-federeatedfilesharing-controller branch from 8013c04 to cb71d52CompareApril 23, 2018 09:10
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 23, 2018
@MorrisJobke
Fix DI for federated file sharing controller
093cd01
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the fix-DI-for-federeatedfilesharing-controller branch from cb71d52 to 093cd01CompareApril 23, 2018 11:49
@codecov

codecovBot commented Apr 23, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9269 into master will decrease coverage by 20.42%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9269 +/- ##
=============================================
- Coverage 51.95% 31.52% -20.43% 
Complexity 25375 25375 =============================================
Files 1607 1607 Lines 95393 95395 +2 Branches 1394 1394 =============================================
- Hits 49559 30073 -19486 - Misses 45834 65322 +19488
Impacted FilesCoverage ΔComplexity Δ
...haring/lib/Controller/RequestHandlerController.php0% <0%> (-30.48%)82 <0> (ø)
...s/federatedfilesharing/lib/AppInfo/Application.php0% <0%> (-64.82%)5 <0> (ø)
apps/files_trashbin/lib/Hooks.php0% <0%> (-100%)3% <0%> (ø)
lib/private/Files/Cache/Wrapper/JailPropagator.php0% <0%> (-100%)1% <0%> (ø)
lib/public/Comments/CommentsEvent.php0% <0%> (-100%)3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php0% <0%> (-100%)1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFix.php0% <0%> (-100%)5% <0%> (ø)
apps/user_ldap/lib/Mapping/GroupMapping.php0% <0%> (-100%)1% <0%> (ø)
lib/public/Files/ForbiddenException.php0% <0%> (-100%)2% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php0% <0%> (-100%)4% <0%> (ø)
... and 370 more

@MorrisJobke
MorrisJobke merged commit 6c6feea into masterApr 23, 2018
@MorrisJobke
MorrisJobke deleted the fix-DI-for-federeatedfilesharing-controller branch April 23, 2018 13:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@schiessleschiessleAwaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@nickvergessen