Federation 2.0 by schiessle · Pull Request #9345 · nextcloud/server

schiessle · 2018-04-30T10:01:55Z

codecov · 2018-05-08T14:02:44Z

Codecov Report

Merging #9345 into master will decrease coverage by 45.46%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9345 +/- ##
============================================
- Coverage 51.8% 6.33% -45.47% - Complexity 26222 26393 +171 
============================================
Files 1673 1690 +17 Lines 96928 97627 +699 Branches 1290 1290 ============================================
- Hits 50209 6184 -44025 - Misses 46719 91443 +44724

Impacted Files	Coverage Δ	Complexity Δ
...dfilesharing/composer/composer/autoload_static.php	`0% <ø> (ø)`	`1 <0> (ø)`	⬇️
lib/private/Server.php	`1.56% <0%> (-80.43%)`	`286 <6> (+6)`
...s/federatedfilesharing/lib/AppInfo/Application.php	`0% <0%> (-63.64%)`	`6 <1> (+1)`
apps/files_sharing/lib/Hooks.php	`0% <0%> (-47.37%)`	`4 <0> (ø)`
apps/files_sharing/lib/AppInfo/Application.php	`0% <0%> (-48.92%)`	`15 <0> (ø)`
...on_api/lib/Controller/RequestHandlerController.php	`0% <0%> (ø)`	`33 <33> (?)`
lib/private/Federation/CloudFederationFactory.php	`0% <0%> (ø)`	`2 <2> (?)`
...lesharing/lib/ocm/CloudFederationProviderFiles.php	`0% <0%> (ø)`	`74 <74> (?)`
...s/cloud_federation_api/lib/AppInfo/Application.php	`0% <0%> (ø)`	`1 <1> (?)`
core/routes.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
... and 961 more

icewind1991 · 2018-06-14T10:36:17Z

+ parent::__construct('cloud_federation_api');
+
+ $container = $this->getContainer();
+ $container->registerCapability(Capabilities::class);


I would prefer if this was moved to a separate register method instead of having the constructor have side effects

most apps I checked, e.g. notifications and activity register the capabilities in the constructor. What side-effects are you referring too? I don't see a real different if I call it manually each time I instantiate the application or if it is done automatically in the constructor.

icewind1991 · 2018-06-14T10:41:40Z

+	public function addShare($shareWith, $name, $description, $providerId, $owner, $ownerDisplayName, $sharedBy, $sharedByDisplayName, $protocol, $shareType, $resourceType) {
+
+ // check if all required parameters are set
+ if ($shareWith === null ||


use strict type hints instead?

not really an option here, because I want to be able to control the exception in case of a missing parameter.

icewind1991 · 2018-06-14T11:14:44Z

+ throw new BadRequestException(['permission']);
+ }
+
+ error_log("new permissions: " . $ncPermissions);


left over debug

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

…ares are enabled for the specific resource type Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle · 2018-07-03T14:31:21Z

I think the failing tests can be ignored, they fail randomly and I don't see how they are connected to this PR. Looking for your final 👍 😉

rullzer

Huge and scarry. But seems to work. Lets do this.

daraelmin · 2020-08-20T15:44:12Z

Not sur, but I think this pull request should sollve issue #1440 (Allow the implementation of federated calendar and contact sharing) and... there's a bounty on it. Maybe someone should take it.

https://www.bountysource.com/issues/37963414-federated-calendar-and-contacts-sharing-210-00

Many many many thanks to the dev for your work !
Cheers

schiessle force-pushed the federation20 branch from 516fffb to 557d129Compare April 30, 2018 14:30

MorrisJobke added 2. developing Work in progress enhancement feature: sharing labels May 7, 2018

schiessle force-pushed the federation20 branch from 557d129 to 5c29be2Compare May 8, 2018 14:02

schiessle force-pushed the federation20 branch 5 times, most recently from 20ccb81 to cbfd266Compare May 14, 2018 10:45

schiessle force-pushed the federation20 branch 2 times, most recently from 5e06045 to 0e76f93Compare May 30, 2018 15:46

schiessle mentioned this pull request Jun 5, 2018
propose some changes to the OCM API to move forward to a version 1.0 cs3org/OCM-API#37
Merged

schiessle force-pushed the federation20 branch 9 times, most recently from a0c0cc9 to a4e71fdCompare June 12, 2018 14:59

schiessle requested review from blizzz, icewind1991 and rullzer June 12, 2018 18:32

schiessle added this to the Nextcloud 14 milestone Jun 12, 2018

schiessle added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 12, 2018

icewind1991 requested changes Jun 14, 2018
View reviewed changes

schiessle added 14 commits July 2, 2018 11:29

add ocm-provider to the list of expected files
34c4527
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

remove unused method
5d0d33a
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

update tests
9d145bb
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix notification tests
2e19213
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix external manager tests
9365fd2
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

implement config check
21b8a87
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

make sure that remote url gets stored with a trailing '/'
2781412
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

send the display name back after a federated share was received
22d9246
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

let the actual federated share provider check if incoming/outgoing sh…
5c8b262
…ares are enabled for the specific resource type Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

cleanup variable naming, it is actually a resource type
e251b34
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

add support for different share types
8d4da30
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

remove the makefile
cfb3e80

remove debug output
086e7a0

look for correct OCM permissions
cdf8abb
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle force-pushed the federation20 branch 2 times, most recently from 18606a3 to da256daCompare July 2, 2018 09:54

schiessle added 4 commits July 2, 2018 12:43

always enable cloud federation api
511a34b
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix return type from send share
411bae5
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

remove unused code
ce567b6
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

cache results from ocm end-point discovery
7ff74ae
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle force-pushed the federation20 branch from da256da to 7ff74aeCompare July 2, 2018 10:43

rullzer approved these changes Jul 3, 2018
View reviewed changes

MorrisJobke approved these changes Jul 3, 2018
View reviewed changes

MorrisJobke merged commit 7025f16 into masterJul 3, 2018

MorrisJobke deleted the federation20 branch July 3, 2018 21:13

MorrisJobke mentioned this pull request Jul 4, 2018
Fix integration tests for Federation 2.0 #10102
Merged

michielbdejong mentioned this pull request Aug 10, 2020
Initial Open Cloud Mesh tests pdsinterop/test-suites#19
Merged

juliusknorr mentioned this pull request Nov 20, 2020
Use string for storing a OCM remote id #24247
Merged

Navigation Menu

Uh oh!

Uh oh!

Federation 2.0 - #9345

Federation 2.0#9345
MorrisJobke merged 39 commits into
masterfrom
federation20

schiessle commented Apr 30, 2018•
edited
Loading

Uh oh!

codecovBot commented May 8, 2018•
edited
Loading

Uh oh!

icewind1991Jun 14, 2018

Uh oh!

schiessleJun 25, 2018

Uh oh!

icewind1991Jun 14, 2018

Uh oh!

schiessleJun 25, 2018

Uh oh!

icewind1991Jun 14, 2018

Uh oh!

schiessleJun 25, 2018

Uh oh!

schiessle commented Jul 3, 2018

Uh oh!

rullzer left a comment

Uh oh!

daraelmin commented Aug 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

schiessle commented Apr 30, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented May 8, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

icewind1991Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

schiessleJun 25, 2018

Choose a reason for hiding this comment

Uh oh!

icewind1991Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

schiessleJun 25, 2018

Choose a reason for hiding this comment

Uh oh!

icewind1991Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

schiessleJun 25, 2018

Choose a reason for hiding this comment

Uh oh!

schiessle commented Jul 3, 2018

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

daraelmin commented Aug 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

schiessle commented Apr 30, 2018•
edited
Loading

codecovBot commented May 8, 2018•
edited
Loading