Issue #9318: catch exceptions in SCSSCacher::resetCache()

[Cybso]

Fixes hard fails when SCSSCacher::resetCache() is not able to delete a cached file, as described in issue #9318 after an upgrade from Nextcloud 13.0.0.0 to 13.0.0.2.

[codecov]

Codecov Report

Merging #9352 into master will increase coverage by 0.72%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #9352 +/- ##
============================================
+ Coverage 51.2% 51.93% +0.72% + Complexity 25580 25395 -185 
============================================
Files 1563 1608 +45 Lines 88054 95447 +7393 Branches 0 1393 +1393 ============================================
+ Hits 45087 49566 +4479 - Misses 42967 45881 +2914

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Template/SCSSCacher.php	71.62% <100%> (-0.8%)	39 <4> (+1)
settings/Controller/LogSettingsController.php	0% <0%> (-30%)	1% <0%> (-2%)
apps/admin_audit/lib/AppInfo/Application.php	8.39% <0%> (-5.18%)	20% <0%> (-2%)
lib/private/Log/File.php	56.04% <0%> (-4.19%)	30% <0%> (-1%)
apps/files_trashbin/lib/Trashbin.php	72.46% <0%> (-0.25%)	136% <0%> (ø)
...e/AppFramework/DependencyInjection/DIContainer.php	82.8% <0%> (-0.08%)	54% <0%> (ø)
lib/private/Log/Rotate.php	0% <0%> (ø)	4% <0%> (+2%)	⬆️
apps/dav/appinfo/routes.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
...dmin_audit/composer/composer/autoload_classmap.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
... and 106 more

[rullzer]

I guess it is not the NotPermittedException that gets thrown here... (I know the phpdoc says that is what it throws). But I guess it fails on some uncatched thing deep in the code.

Better catch a bit more generic here I think

[Cybso]

@rullzer Have a look at the stack trace in #9318 : Actually it isNotPermittedException that is thrown here, although I wasn't able to determine the root cause because the problem was not reproducible once the cache has been resetted (I've tried to reset the ownership and mode of the files in the data directory before I've modified the code, of course - it didn't solved the problem). Nevertheless, other people reported the same exception in SCSSCacher::resetCache:

• https://help.nextcloud.com/t/solved-nc12-internal-server-error-after-login/13256/6
• https://help.nextcloud.com/t/manual-upgrade-nc13-failed/27938/11

[rullzer]

ok then lets do this!

[juliusknorr]

rebased to trigger ci again

[MorrisJobke]

@Cybso Mind to open a backport PR? Just base a branch on stable13, cherry-pick the commit from there onto it and then create a PR on GitHub against stable13.

[Cybso]

@MorrisJobke I tried in #9376, but I think I accidentally merged all changes in master...?!

Here's what I did:

git pull
git checkout stable13
git checkout -b 9318_SCSSCacher_resetCache_catch_exception_stable13
git cherry-pick -m 1 -x 0f8210792ce4bb786bed9fe09b97a4ec9f4d848e
git push origin 9318_SCSSCacher_resetCache_catch_exception_stable13

[MorrisJobke]

@Cybso Just use the commit sha from this PR:

git checkpick 6270a01cab3d6cce864b8b795749598f9d65b6c3

That then should work ;)

[Cybso]

Ok, I think I got it right, now :-)