Skip to content

[stable12] Replace deprecated sinon reset() call with resetHistory() - #9359

Merged
skjnldsv merged 1 commit into
stable12from
stable12-9348
May 2, 2018
Merged

[stable12] Replace deprecated sinon reset() call with resetHistory()#9359
skjnldsv merged 1 commit into
stable12from
stable12-9348

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented May 2, 2018

Copy link
Copy Markdown
Member

backport of #9348 to fix the failing jsunit tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 2, 2018
@codecov

codecovBot commented May 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9359 into stable12 will increase coverage by 0.24%.
The diff coverage is n/a.

@@ Coverage Diff @@## stable12 #9359 +/- ##
==============================================
+ Coverage 53.66% 53.91% +0.24% 
Complexity 22785 22785 ==============================================
Files 1325 1387 +62 Lines 79765 87300 +7535 Branches 0 1331 +1331 ==============================================
+ Hits 42803 47064 +4261 - Misses 36962 40236 +3274
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
core/js/oc-backbone-webdav.js85.41% <0%> (ø)0% <0%> (?)
apps/files_sharing/js/sharetabview.js83.33% <0%> (ø)0% <0%> (?)
core/js/contactsmenu.js90% <0%> (ø)0% <0%> (?)
apps/files_external/js/mountsfilelist.js87.27% <0%> (ø)0% <0%> (?)
core/js/config.js6.66% <0%> (ø)0% <0%> (?)
apps/files_sharing/js/public.js47.91% <0%> (ø)0% <0%> (?)
apps/files_external/js/app.js15.9% <0%> (ø)0% <0%> (?)
core/js/public/appconfig.js4.76% <0%> (ø)0% <0%> (?)
core/js/share.js40.98% <0%> (ø)0% <0%> (?)
... and 53 more

@skjnldsv
skjnldsv merged commit 056f62d into stable12May 2, 2018
@skjnldsv
skjnldsv deleted the stable12-9348 branch May 2, 2018 08:24
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@rullzer@MorrisJobke@skjnldsv