Fix "Invalid argument supplied for foreach()"

[GitHubUser4234]

Fixes#7804

[MorrisJobke]

cc @nextcloud/ldap

[MorrisJobke]

Code makes sense 👍

[blizzz]

👍 make sense.

In future, please use short notations [ … ] for arrays.

[blizzz]

@GitHubUser4234 tests are failing

[codecov]

Codecov Report

Merging #9360 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #9360 +/- ##
============================================
- Coverage 51.76% 51.61% -0.16% - Complexity 25562 25684 +122 
============================================
Files 1627 1638 +11 Lines 95952 96283 +331 Branches 1393 1393 ============================================
+ Hits 49673 49697 +24 - Misses 46279 46586 +307

Impacted Files	Coverage Δ	Complexity Δ
apps/user_ldap/lib/User/User.php	75.25% <100%> (ø)	123 <0> (ø)	⬇️
apps/files_versions/lib/AppInfo/Application.php	68.75% <0%> (-31.25%)	3% <0%> (+1%)
apps/files_external/lib/Lib/Storage/OwnCloud.php	84% <0%> (-7.31%)	7% <0%> (+1%)
lib/private/Log.php	73.07% <0%> (-4.46%)	35% <0%> (-5%)
lib/private/Template/SCSSCacher.php	71.62% <0%> (-0.8%)	39% <0%> (+1%)
lib/private/Settings/Manager.php	64.33% <0%> (-0.67%)	42% <0%> (ø)
apps/dav/lib/Connector/Sabre/File.php	72.79% <0%> (-0.42%)	100% <0%> (-3%)
lib/private/Files/View.php	85.08% <0%> (-0.21%)	380% <0%> (ø)
apps/files_sharing/lib/External/Storage.php	14.88% <0%> (-0.18%)	59% <0%> (+1%)
lib/private/Server.php	82.56% <0%> (-0.02%)	280% <0%> (+2%)
... and 48 more

[GitHubUser4234]

@blizzz yeah, unit tests had to be adjusted also ^^

[rullzer]

Awesome stuff once agian @GitHubUser4234 thnx

[MorrisJobke]

@GitHubUser4234@blizzz@rullzer Maybe worth a backport, right?

[MorrisJobke]

backport is in #9654