Skip to content

Fix jsunit tests - #9407

Merged
skjnldsv merged 1 commit into
masterfrom
fix-jsunit
May 7, 2018
Merged

Fix jsunit tests#9407
skjnldsv merged 1 commit into
masterfrom
fix-jsunit

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented May 7, 2018

Copy link
Copy Markdown
Member

Seems like the behaviour changed somewhere between sinon version 5.0.1 and the current 5.0.5, but I could not find any reference in the changes.

Anyhow this fixes the jsunit tests in drone again. We should also backport this back to stable13/stable12, as it is broken there as well.

Please review @nextcloud/javascript

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added 2. developing Work in progress bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 7, 2018
@juliusknorrjuliusknorr added this to the Nextcloud 14 milestone May 7, 2018
@codecov

codecovBot commented May 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9407 into master will increase coverage by 0.57%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9407 +/- ##
============================================
+ Coverage 51.1% 51.68% +0.57% 
Complexity 25654 25654 ============================================
Files 1569 1636 +67 Lines 88234 96176 +7942 Branches 0 1393 +1393 ============================================
+ Hits 45095 49709 +4614 - Misses 43139 46467 +3328
Impacted FilesCoverage ΔComplexity Δ
core/js/oc-dialogs.js0.43% <0%> (ø)0% <0%> (?)
core/js/oc-backbone.js100% <0%> (ø)0% <0%> (?)
core/js/config.js6.66% <0%> (ø)0% <0%> (?)
core/js/files/client.js85.26% <0%> (ø)0% <0%> (?)
core/js/l10n.js97.29% <0%> (ø)0% <0%> (?)
core/js/mimetypelist.js100% <0%> (ø)0% <0%> (?)
apps/files_sharing/js/public.js47.91% <0%> (ø)0% <0%> (?)
core/js/public/appconfig.js4.76% <0%> (ø)0% <0%> (?)
core/js/files/fileinfo.js100% <0%> (ø)0% <0%> (?)
apps/files_sharing/js/sharetabview.js86.66% <0%> (ø)0% <0%> (?)
... and 59 more

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weeee

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 7, 2018
@skjnldsv
skjnldsv merged commit 94010e9 into masterMay 7, 2018
@skjnldsv
skjnldsv deleted the fix-jsunit branch May 7, 2018 10:16
This was referenced May 9, 2018
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

stable12 #9431
stable13 #9430

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@MorrisJobke@skjnldsv