Skip to content

Add PHP missing message to index.php - #9418

Merged
MorrisJobke merged 1 commit into
masterfrom
php-message-indexphp
May 8, 2018
Merged

Add PHP missing message to index.php#9418
MorrisJobke merged 1 commit into
masterfrom
php-message-indexphp

Conversation

@MariusBluem

Copy link
Copy Markdown
Member

As discussed with @karlitschek and @schiessle 🤣

Signed-off-by: Marius Blüm marius@lineone.io

Signed-off-by: Marius Blüm <marius@lineone.io>
@MariusBluemMariusBluem added the 3. to review Waiting for reviews label May 8, 2018
@MariusBluemMariusBluem added this to the Nextcloud 14 milestone May 8, 2018
@codecov

codecovBot commented May 8, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9418 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9418 +/- ##
============================================
+ Coverage 51.61% 51.62% +<.01% 
Complexity 25679 25679 ============================================
Files 1638 1638 Lines 96274 96272 -2 Branches 1393 1393 ============================================
Hits 49696 49696 + Misses 46578 46576 -2
Impacted FilesCoverage ΔComplexity Δ
index.php0% <ø> (ø)0 <0> (ø)⬇️

@karlitschek

Copy link
Copy Markdown
Member

👍

@MorrisJobke

Copy link
Copy Markdown
Member

@karlitschek Be aware of the GitHub review feature - then I don't need to forcefully merge this, but the merge button actually gets green because of two approvals ;)

bildschirmfoto 2018-05-08 um 17 00 26

@MorrisJobke
MorrisJobke merged commit 4327eea into masterMay 8, 2018
@MorrisJobke
MorrisJobke deleted the php-message-indexphp branch May 8, 2018 15:01
@MorrisJobke

Copy link
Copy Markdown
Member

@MariusBluem Please backport to stable13

@karlitschek

Copy link
Copy Markdown
Member

@MorrisJobke Got it. Sorry :-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MariusBluem@karlitschek@MorrisJobke@rullzer