Uh oh!
There was an error while loading. Please reload this page.
Use APCu caching of composer - #9442
Merged
Merged
Conversation
Should potentially shave of a few ms when loading classes of apps that don't ship their own autoloader. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, icewind1991 and nickvergessenMay 10, 2018 10:40
icewind1991
approved these changes
May 10, 2018
| } catch (\Exception $ex) { | ||
| } | ||
| self::$composerAutoloader->setApcuPrefix($instanceId . '-mainComposer'); |
Member
There was a problem hiding this comment.
PHP Fatal error: Uncaught Error: Call to undefined method Composer\Autoload\ClassLoader::setApcuPrefix() in one of the integration tests 🙈
MemberAuthor
There was a problem hiding this comment.
Sounds like dark magic... lets see why
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@## master #9442 +/- ##
===========================================
- Coverage 51.61% 51.6% -0.01% - Complexity 25694 25698 +4
===========================================
Files 1638 1638 Lines 96318 96324 +6 Branches 1393 1393 ===========================================
- Hits 49712 49706 -6 - Misses 46606 46618 +12
|
nickvergessen
commented
Sep 19, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should potentially shave of a few ms when loading classes of apps that
don't ship their own autoloader.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl