Skip to content

Move versions webui to DAV - #9450

Closed
rullzer wants to merge 4 commits into
masterfrom
feature/9385/version_webui_to_dav
Closed

Move versions webui to DAV#9450
rullzer wants to merge 4 commits into
masterfrom
feature/9385/version_webui_to_dav

Conversation

@rullzer

@rullzerrullzer commented May 10, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Now that we have a fancy DAV endpoint we better use it!

Fixes#9385

  • Use the backbone webdav code.
  • Fetch all versions at once

Todo:

  • Restore via DAV
  • Download via DAV
    • Proper filename when downloading via DAV
  • Fix tests

@rullzer
Get version list via DAV
90416ca
Now that we have a fancy DAV endpoint we better use it!
* Use the backbone webdav code.
* Fetch all versions at once
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 14 milestone May 10, 2018
@rullzerrullzer changed the title Get version list via DAVMove versions webui to DAVMay 10, 2018
rullzer added 3 commits May 11, 2018 14:09
@rullzer
Handle download via DAV
351eb78
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Restore via DAV
c387b49
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Kill off old endpoints
7bc03a8
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented May 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9450 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9450 +/- ##
============================================
- Coverage 51.61% 51.03% -0.59% 
Complexity 25694 25694 ============================================
Files 1638 1571 -67 Lines 96318 88376 -7942 Branches 1393 0 -1393 ============================================
- Hits 49712 45099 -4613 + Misses 46606 43277 -3329
Impacted FilesCoverage ΔComplexity Δ
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
core/js/mimetype.js
apps/comments/js/commentsummarymodel.js
core/js/multiselect.js
core/vendor/marked/marked.min.js
core/js/sharedialogview.js
apps/files_sharing/js/files_drop.js
apps/comments/js/commentsmodifymenu.js
apps/comments/js/filesplugin.js
...mments/js/vendor/At.js/dist/js/jquery.atwho.min.js
... and 55 more

@MorrisJobkeMorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@rullzerrullzer mentioned this pull request Oct 12, 2018
Merged
@rullzer

rullzer commented Oct 12, 2018

Copy link
Copy Markdown
MemberAuthor

See #11778

@rullzerrullzer closed this Oct 12, 2018
@nextcloud-botnextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 12, 2018
@rullzer
rullzer deleted the feature/9385/version_webui_to_dav branch October 12, 2018 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danxuliudanxuliu

Labels

2. developingWork in progressenhancementfeature: davfeature: versionstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@MorrisJobke@nextcloud-bot@danxuliu