Skip to content

Delete the previews when a version is restored - #9475

Merged
MorrisJobke merged 1 commit into
masterfrom
bug/9469/delete_preview_on_version_restore
May 16, 2018
Merged

Delete the previews when a version is restored#9475
MorrisJobke merged 1 commit into
masterfrom
bug/9469/delete_preview_on_version_restore

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#9469

When a version of a file is restored the previews are no longer valid.
Thus we should remove them so they are regenerated.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes#9469
When a version of a file is restored the previews are no longer valid.
Thus we should remove them so they are regenerated.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented May 14, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9475 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@ Coverage Diff @@## master #9475 +/- ##
============================================
+ Coverage 51.71% 51.72% +<.01% - Complexity 25696 25699 +3 
============================================
Files 1640 1640 Lines 96337 96346 +9 Branches 1393 1393 ============================================
+ Hits 49823 49833 +10 + Misses 46514 46513 -1
Impacted FilesCoverage ΔComplexity Δ
apps/files_versions/lib/Storage.php66.32% <100%> (+0.25%)103 <0> (ø)⬇️
lib/private/Preview/WatcherConnector.php91.66% <100%> (+0.75%)5 <0> (ø)⬇️
lib/private/Preview/Watcher.php64.28% <40%> (-13.5%)7 <5> (+3)
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
core/js/js.js65.96% <0%> (+0.55%)0% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 0011bfb into masterMay 16, 2018
@MorrisJobke
MorrisJobke deleted the bug/9469/delete_preview_on_version_restore branch May 16, 2018 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@icewind1991