Skip to content

[stable13] allow to specify a link to a legal notice - #9516

Merged
MorrisJobke merged 1 commit into
stable13from
backport/9437/stable13
May 22, 2018
Merged

[stable13] allow to specify a link to a legal notice#9516
MorrisJobke merged 1 commit into
stable13from
backport/9437/stable13

Conversation

@blizzz

Copy link
Copy Markdown
Member

Backport of #9437

allow to specify a link to a legal notice
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
fix tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
fix undo for url-typed inputs
and minor adjustments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Use link not address in labels for URLs
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
this file does not belong here
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@codecov

codecovBot commented May 18, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9516 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@ Coverage Diff @@## stable13 #9516 +/- ##
==============================================
- Coverage 51.38% 51.38% -0.01% - Complexity 25052 25057 +5 
==============================================
Files 1609 1609 Lines 95350 95373 +23 Branches 1376 1376 ==============================================
+ Hits 48999 49010 +11 - Misses 46351 46363 +12
Impacted FilesCoverage ΔComplexity Δ
apps/theming/templates/settings-admin.php0% <0%> (ø)0 <0> (ø)⬇️
apps/theming/lib/Settings/Admin.php86.48% <100%> (+0.37%)5 <0> (ø)⬇️
apps/theming/lib/ThemingDefaults.php92.25% <100%> (+0.46%)49 <1> (+3)⬆️
apps/theming/lib/Controller/ThemingController.php73.16% <20%> (-2.03%)45 <0> (+2)

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 5744827 into stable13May 22, 2018
@MorrisJobke
MorrisJobke deleted the backport/9437/stable13 branch May 22, 2018 14:54
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
@giteck

Copy link
Copy Markdown

This app was really needed, and is working fine, thank you!
But there is still one issue: the file with legal notice makes nextcloud to fail the integrity check. In which directory should it be placed in order to avoid this?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@giteck@rullzer@MorrisJobke