Skip to content

[stable13] Fix translation bug on lost password page - #9548

Merged
MorrisJobke merged 1 commit into
nextcloud:stable13from
remyj38:stable13
May 22, 2018
Merged

[stable13] Fix translation bug on lost password page#9548
MorrisJobke merged 1 commit into
nextcloud:stable13from
remyj38:stable13

Conversation

@remyj38

Copy link
Copy Markdown
Contributor

During resetting user's password, the controller return the untranslated message (from basic exception) instead of the hint message (translated).

Fixnextcloud/password_policy#26

Signed-off-by: Rémy Jacquin remy@remyj.fr

Fixnextcloud/password_policy#26
Signed-off-by: Rémy Jacquin <remy@remyj.fr>

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤖

@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews labels May 22, 2018
@ChristophWurstChristophWurst added this to the Nextcloud 13.0.3 milestone May 22, 2018
@codecov

codecovBot commented May 22, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9548 into stable13 will decrease coverage by <.01%.
The diff coverage is 50%.

@@ Coverage Diff @@## stable13 #9548 +/- ##
==============================================
- Coverage 51.38% 51.38% -0.01% - Complexity 25057 25058 +1 
==============================================
Files 1609 1609 Lines 95373 95375 +2 Branches 1376 1376 ==============================================
- Hits 49010 49006 -4 - Misses 46363 46369 +6
Impacted FilesCoverage ΔComplexity Δ
core/Controller/LostController.php79.35% <50%> (-0.39%)33 <0> (+1)
core/js/js.js65.81% <0%> (-0.56%)0% <0%> (ø)

@MorrisJobke
MorrisJobke merged commit 04ff701 into nextcloud:stable13May 22, 2018
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@remyj38@MorrisJobke@ChristophWurst