Skip to content

[stable12] Fix translation bug on lost password page - #9549

Merged
MorrisJobke merged 1 commit into
nextcloud:stable12from
remyj38:stable12
May 22, 2018
Merged

[stable12] Fix translation bug on lost password page#9549
MorrisJobke merged 1 commit into
nextcloud:stable12from
remyj38:stable12

Conversation

@remyj38

Copy link
Copy Markdown
Contributor

During resetting user's password, the controller return the untranslated message (from basic exception) instead of the hint message (translated).

Fixnextcloud/password_policy#26

Signed-off-by: Rémy Jacquin remy@remyj.fr

Fixnextcloud/password_policy#26
Signed-off-by: Rémy Jacquin <remy@remyj.fr>

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews labels May 22, 2018
@ChristophWurstChristophWurst added this to the Nextcloud 12.0.8 milestone May 22, 2018
@codecov

codecovBot commented May 22, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9549 into stable12 will decrease coverage by <.01%.
The diff coverage is 50%.

@@ Coverage Diff @@## stable12 #9549 +/- ##
==============================================
- Coverage 53.91% 53.91% -0.01% - Complexity 22785 22786 +1 
==============================================
Files 1387 1387 Lines 87300 87302 +2 Branches 1331 1331 ==============================================
+ Hits 47070 47071 +1 - Misses 40230 40231 +1
Impacted FilesCoverage ΔComplexity Δ
core/Controller/LostController.php80.13% <50%> (-0.41%)30 <0> (+1)

@MorrisJobke
MorrisJobke merged commit 2c64557 into nextcloud:stable12May 22, 2018
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@remyj38@MorrisJobke@ChristophWurst