Uh oh!
There was an error while loading. Please reload this page.
Emit event when running ./occ db:add-missing-indices - #9576
Merged
Conversation
rullzer
requested review from
ChristophWurst, MorrisJobke, juliusknorr and schiessleMay 24, 2018 08:40
juliusknorr
requested changes
May 24, 2018
| * @param IDBConnection $connection | ||
| */ | ||
| public function __construct(IDBConnection $connection) { | ||
| public function __construct(IDBConnection $connection, EventDispatcherInterface $dispatcher) { |
Member
There was a problem hiding this comment.
You're missing the assignment of $dispatcher to the private field.
rullzerforce-pushed
the
feature/noid/missing_index_event
branch
from
May 24, 2018 09:16
0830a8f to
91ec554CompareCodecov Report
@@ Coverage Diff @@## master #9576 +/- ##
=============================================
+ Coverage 29.13% 51.18% +22.04%
Complexity 25673 25673 =============================================
Files 1568 1568 Lines 87950 87953 +3 =============================================
+ Hits 25623 45015 +19392 + Misses 62327 42938 -19389
|
juliusknorr
approved these changes
May 24, 2018
MorrisJobke
commented
May 24, 2018
Member
Retriggered CI job |
| */ | ||
| interface IDBConnection { | ||
| const ADD_MISSING_INDEXES_EVENT = this::class . '::ADD_MISSING_INDEXES'; |
Member
There was a problem hiding this comment.
lib/public/IDBConnection.php:49 PhanUndeclaredClassConstant Reference to constant class from undeclared class \OCP\this
Member
There was a problem hiding this comment.
I fixed it by replacing the this with self 😉
This allows apps to listen to this event in order to also update indecies there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobkeforce-pushed
the
feature/noid/missing_index_event
branch
from
May 24, 2018 16:03
91ec554 to
80cc8d0Comparerullzer
commented
May 24, 2018
MemberAuthor
Would a backport make sense? it is a small change but then apps can already add indexes for 13 apps. |
MorrisJobke
commented
May 25, 2018
Member
I would say so. |
rullzer
commented
May 26, 2018
MemberAuthor
backport in #9620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows apps to listen to this event in order to also update
indecies there.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl