Skip to content

[stable13] Limit Sinon version to 5.0.7 at most - #9629

Merged
rullzer merged 1 commit into
stable13from
backport/9627/stable13
May 28, 2018
Merged

[stable13] Limit Sinon version to 5.0.7 at most#9629
rullzer merged 1 commit into
stable13from
backport/9627/stable13

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented May 28, 2018

Copy link
Copy Markdown
Member

Backport of #9627

@danxuliu@MorrisJobke
Limit Sinon version to 5.0.7 at most
fe93f09
When using fake servers with Sinon.JS, the JavaScript test framework,
the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of
XMLHttpRequest was modified to normalize the header values (as requested
by the spec), but since then only string values are accepted; null or
integer values can no longer be passed to "setRequestHeader", as it
expects the "replace" function to be available in the object. However,
in the tests null and integer values are passed to "setRequestHeader",
which causes them to fail.
Both Firefox and Chromium accept passing non-string values to their
"setRequestHeader" implementation, and it is done, for example, in
davclient.js; it is not clear yet whether Sinon got too restrictive or
the code calling "setRequestHeader" was too loose. Given that
davclient.js is an external dependency, as a temporary measure Sinon
version is forced to be 5.0.7 at most until either Sinon or davclient.js
are updated.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label May 28, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 13.0.3 milestone May 28, 2018
@MorrisJobke

MorrisJobke commented May 28, 2018

Copy link
Copy Markdown
MemberAuthor

👍 from my side as well

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2018
danxuliu
danxuliu approved these changes May 28, 2018
View reviewed changes

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for CI before merging to be sure, but it should pass ;-)

@codecov

codecovBot commented May 28, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9629 into stable13 will increase coverage by 0.53%.
The diff coverage is n/a.

@@ Coverage Diff @@## stable13 #9629 +/- ##
=============================================
+ Coverage 50.87% 51.4% +0.53% 
Complexity 25097 25097 =============================================
Files 1547 1612 +65 Lines 87719 95520 +7801 Branches 0 1376 +1376 =============================================
+ Hits 44628 49104 +4476 - Misses 43091 46416 +3325
Impacted FilesCoverage ΔComplexity Δ
apps/comments/js/app.js100% <0%> (ø)0% <0%> (?)
core/js/octemplate.js11.11% <0%> (ø)0% <0%> (?)
apps/files_versions/js/versionmodel.js96.42% <0%> (ø)0% <0%> (?)
core/js/systemtags/systemtagsmappingcollection.js68.42% <0%> (ø)0% <0%> (?)
apps/files_sharing/js/app.js77.1% <0%> (ø)0% <0%> (?)
core/js/multiselect.js2.33% <0%> (ø)0% <0%> (?)
apps/systemtags/js/systemtagsinfoview.js98.27% <0%> (ø)0% <0%> (?)
core/js/sharesocialmanager.js87.5% <0%> (ø)0% <0%> (?)
apps/systemtags/js/filesplugin.js25% <0%> (ø)0% <0%> (?)
core/js/public/appconfig.js4.76% <0%> (ø)0% <0%> (?)
... and 55 more

@rullzer
rullzer merged commit c07f23c into stable13May 28, 2018
@rullzer
rullzer deleted the backport/9627/stable13 branch May 28, 2018 11:27
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@danxuliudanxuliudanxuliu approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 13.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@skjnldsv@danxuliu@rullzer