Skip to content

Fix drone mysqlmb4 tests - #9670

Merged
rullzer merged 1 commit into
masterfrom
drone-mysqlmb4-fix
May 30, 2018
Merged

Fix drone mysqlmb4 tests#9670
rullzer merged 1 commit into
masterfrom
drone-mysqlmb4-fix

Conversation

@skjnldsv

@skjnldsvskjnldsv commented May 30, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

see: docker-library/mysql#303 (comment)

@skjnldsv
Fix drone mysqlmb4 tests
aec85bf
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv self-assigned this May 30, 2018
@skjnldsvskjnldsv added the 3. to review Waiting for reviews label May 30, 2018
rullzer
rullzer approved these changes May 30, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do it like this for now

@codecov

codecovBot commented May 30, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9670 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9670 +/- ##
============================================
+ Coverage 51.73% 51.73% +<.01% 
Complexity 25709 25709 ============================================
Files 1635 1635 Lines 95963 95963 Branches 1384 1384 ============================================
+ Hits 49646 49647 +1 + Misses 46317 46316 -1
Impacted FilesCoverage ΔComplexity Δ
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.7% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2018
@rullzer
rullzer merged commit e8c680f into masterMay 30, 2018
@rullzer
rullzer deleted the drone-mysqlmb4-fix branch May 30, 2018 06:52
This was referenced May 30, 2018
Merged
Merged
@skjnldsv

skjnldsv commented May 30, 2018

Copy link
Copy Markdown
MemberAuthor

Backports: #9671#9672

@MorrisJobke

MorrisJobke commented May 30, 2018

Copy link
Copy Markdown
Member

Thanks - you rock

@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone May 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@blizzzblizzzAwaiting requested review from blizzz
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@rullzer