Uh oh!
There was an error while loading. Please reload this page.
[stable13] Make sure the log doesn't try to read from PUT if it can't - #9694
Merged
Conversation
If a PUT request comes in that is not JSON or from encoded. Then we can only read it (exactly) once. If that is the case we must assume no shared secret is set. If we don't then we either are the first to read it, thus causing the real read of the data to fail. Or we are later and then it throws an exception (also failing the request). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst, MorrisJobke, danxuliu and icewind1991May 30, 2018 18:27
Codecov Report
@@ Coverage Diff @@## stable13 #9694 +/- ##
==============================================
- Coverage 51.43% 51.43% -0.01% - Complexity 25106 25109 +3
==============================================
Files 1612 1612 Lines 95544 95549 +5 Branches 1376 1376 ==============================================
Hits 49143 49143 - Misses 46401 46406 +5
|
Merged
skjnldsv
approved these changes
Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9692
Deployed on our instance and fixes the issue