Skip to content

Fix the master unit tests - #9711

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/noid/fixmaster_unittests
Jun 1, 2018
Merged

Fix the master unit tests#9711
MorrisJobke merged 1 commit into
masterfrom
fix/noid/fixmaster_unittests

Conversation

@rullzer

@rullzerrullzer commented Jun 1, 2018

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Fix the master unit tests
3ca1525
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added the 3. to review Waiting for reviews label Jun 1, 2018
@rullzerrullzer added this to the Nextcloud 14 milestone Jun 1, 2018
MorrisJobke
MorrisJobke approved these changes Jun 1, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@codecov

codecovBot commented Jun 1, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9711 into master will increase coverage by 20.27%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9711 +/- ##
=============================================
+ Coverage 31.44% 51.72% +20.27% 
Complexity 25729 25729 =============================================
Files 1635 1635 Lines 96017 96017 Branches 1384 1384 =============================================
+ Hits 30190 49661 +19471 + Misses 65827 46356 -19471
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Stream/Encryption.php75.22% <0%> (+0.45%)54% <0%> (ø)⬇️
apps/theming/lib/ThemingDefaults.php90% <0%> (+0.62%)56% <0%> (ø)⬇️
lib/private/Setup.php12.55% <0%> (+0.83%)52% <0%> (ø)⬇️
lib/public/AppFramework/Db/Mapper.php94.95% <0%> (+0.84%)30% <0%> (ø)⬇️
lib/private/Group/Group.php82.75% <0%> (+0.86%)56% <0%> (ø)⬇️
...vate/Authentication/Token/DefaultTokenProvider.php98.03% <0%> (+0.98%)32% <0%> (ø)⬇️
lib/private/Preview/Generator.php78.28% <0%> (+1.14%)53% <0%> (ø)⬇️
lib/private/App/DependencyAnalyzer.php95.62% <0%> (+1.25%)64% <0%> (ø)⬇️
lib/private/Settings/Manager.php64.33% <0%> (+1.39%)42% <0%> (ø)⬇️
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️
... and 377 more

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 1, 2018
@MorrisJobke
MorrisJobke merged commit 38c38ee into masterJun 1, 2018
@MorrisJobke
MorrisJobke deleted the fix/noid/fixmaster_unittests branch June 1, 2018 12:10
@MorrisJobke

MorrisJobke commented Jun 1, 2018

Copy link
Copy Markdown
Member

Ref #9550

@MorrisJobke

MorrisJobke commented Jun 1, 2018

Copy link
Copy Markdown
Member

Let's backport this to stable13 as well

@MorrisJobkeMorrisJobke mentioned this pull request Jun 1, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@blizzzblizzzblizzz approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@danxuliudanxuliuAwaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@blizzz