Skip to content

Add parent index to share table - #9724

Merged
MorrisJobke merged 1 commit into
masterfrom
feature/9327/parent_share_index
Jun 4, 2018
Merged

Add parent index to share table#9724
MorrisJobke merged 1 commit into
masterfrom
feature/9327/parent_share_index

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#9327

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes#9327
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Jun 3, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9724 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9724 +/- ##
============================================
- Coverage 51.72% 51.72% -0.01% - Complexity 25733 25734 +1 
============================================
Files 1636 1636 Lines 96030 96037 +7 Branches 1384 1384 ============================================
Hits 49672 49672 - Misses 46358 46365 +7
Impacted FilesCoverage ΔComplexity Δ
core/Migrations/Version13000Date20170718121200.php0% <0%> (ø)30 <0> (ø)⬇️
core/Command/Db/AddMissingIndices.php0% <0%> (ø)8 <0> (+1)⬆️

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 2d2c9ec into masterJun 4, 2018
@MorrisJobke
MorrisJobke deleted the feature/9327/parent_share_index branch June 4, 2018 13:39
@MorrisJobke

Copy link
Copy Markdown
Member

@rullzer Should this be back ported?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst