Uh oh!
There was an error while loading. Please reload this page.
[stable13] Fix local users check in contacts menu - #9732
Merged
MorrisJobke merged 2 commits intoJun 4, 2018
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
| } | ||
| if ($shareType === 0 || $shareType === 6) { | ||
| if ($contact['UID'] === $shareWith && $contact['isLocalSystemBook'] === true) { | ||
| $isLocal = $contact['isLocalSystemBook'] ?? false; |
Member
There was a problem hiding this comment.
PHP 7.0+ only operator 😉 Use this instead:
$isLocal = isset($contact['isLocalSystemBook']) ? $contact['isLocalSystemBook'] : false;Member
There was a problem hiding this comment.
And CI would have catched this 🚀 🙌 https://drone.nextcloud.com/nextcloud/server/7709/90
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Codecov Report
@@ Coverage Diff @@## stable13 #9732 +/- ##
==============================================
+ Coverage 51.44% 51.44% +<.01% - Complexity 25130 25131 +1
==============================================
Files 1613 1613 Lines 95617 95618 +1 Branches 1376 1376 ==============================================
+ Hits 49188 49190 +2 + Misses 46429 46428 -1
|
MorrisJobke
approved these changes
Jun 4, 2018
rullzer
approved these changes
Jun 4, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9725