Skip to content

allow setting notify credentials in environment - #9787

Merged
MorrisJobke merged 1 commit into
masterfrom
notify-credentials-env
Jun 7, 2018
Merged

allow setting notify credentials in environment#9787
MorrisJobke merged 1 commit into
masterfrom
notify-credentials-env

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jun 7, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Jun 7, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@codecov

codecovBot commented Jun 7, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9787 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9787 +/- ##
============================================
- Coverage 51.94% 51.93% -0.01% - Complexity 25757 25761 +4 
============================================
Files 1634 1634 Lines 95395 95403 +8 Branches 1308 1308 ============================================
Hits 49552 49552 - Misses 45843 45851 +8
Impacted FilesCoverage ΔComplexity Δ
apps/files_external/lib/Command/Notify.php0% <0%> (ø)41 <0> (+4)⬆️
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.7% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit be30c09 into masterJun 7, 2018
@MorrisJobke
MorrisJobke deleted the notify-credentials-env branch June 7, 2018 14:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke