Uh oh!
There was an error while loading. Please reload this page.
Update the token on session regeneration - #9823
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #9823 +/- ##
============================================
- Coverage 51.92% 51.92% -0.01% - Complexity 25787 25791 +4
============================================
Files 1637 1637 Lines 95453 95466 +13 Branches 1318 1318 ============================================
Hits 49567 49567 - Misses 45886 45899 +13
|
rullzerforce-pushed
the
bufgix/noid/update_token_on_session_id_regenerate
branch
2 times, most recently
from
June 11, 2018 11:32
58c69a9 to
091a376Compare| * @param bool $deleteOldSession Whether to delete the old associated session file or not. | ||
| * @param bool $updateToken Wheater to update the associated auth token | ||
| * @return void | ||
| * @since 9.0.0 |
Member
There was a problem hiding this comment.
Document that $updateToken was added in 14.0.0
MorrisJobke
approved these changes
Jun 12, 2018
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Code makes sense beside my little nitpick.
rullzerforce-pushed
the
bufgix/noid/update_token_on_session_id_regenerate
branch
from
June 12, 2018 19:20
091a376 to
708885dCompareSometimes when we force a session regeneration we want to update the current token for this session. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
bufgix/noid/update_token_on_session_id_regenerate
branch
from
June 14, 2018 06:09
708885d to
8c47a63Comparerullzer
commented
Jun 14, 2018
MemberAuthor
Rebased to get green CI. All good now! |
blizzz
approved these changes
Jun 18, 2018
MorrisJobke
commented
Jul 9, 2018
Member
@rullzer What about the backport here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More abstraced form of #9756