Skip to content

Update message shown when unsharing a file - #9893

Merged
juliusknorr merged 1 commit into
nextcloud:masterfrom
kevgathuku:update-unshare-message
Jun 18, 2018
Merged

Update message shown when unsharing a file#9893
juliusknorr merged 1 commit into
nextcloud:masterfrom
kevgathuku:update-unshare-message

Conversation

@kevgathuku

Copy link
Copy Markdown
Contributor

Attempts to fix#9180

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@MorrisJobke

Copy link
Copy Markdown
Member

The CI failure is, because the commit message is missing the sign-off message. You can read more about this at https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work

If you have this branch checked out locally, you could adjust the existing commit by doing this:

git commit --amend -s
git push -f origin update-unshare-message

And welcome as first-time contributor to the Nextcloud project. 🎉

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label Jun 18, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Jun 18, 2018
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
@kevgathuku
kevgathukuforce-pushed the update-unshare-message branch from 5d89d1c to 5d9c1d3CompareJune 18, 2018 10:12
@codecov

codecovBot commented Jun 18, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9893 into master will not change coverage.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9893 +/- ##
=========================================
Coverage 51.92% 51.92% Complexity 25804 25804 =========================================
Files 1637 1637 Lines 95501 95501 Branches 1318 1318 =========================================
Hits 49592 49592 Misses 45909 45909
Impacted FilesCoverage ΔComplexity Δ
...pps/files_sharing/lib/Activity/Providers/Users.php0% <0%> (ø)23 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.46% <0%> (-0.25%)136% <0%> (ø)
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@kevgathuku

Copy link
Copy Markdown
ContributorAuthor

Thanks for the pointers @MorrisJobke. I've been able to add the sign-off message.
And thanks for the welcome, it's exciting to contribute to this awesome project 😄

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish backport-request and removed 3. to review Waiting for reviews labels Jun 18, 2018
@juliusknorr
juliusknorr merged commit 5b60508 into nextcloud:masterJun 18, 2018
@kevgathuku
kevgathuku deleted the update-unshare-message branch June 18, 2018 15:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unfortunate notification wording when removing share

4 participants

@kevgathuku@MorrisJobke@juliusknorr@skjnldsv