implement federated group sharing by schiessle · Pull Request #9895 · nextcloud/server

schiessle · 2018-06-18T09:55:52Z

Allows you to share a file/folder with a group on a different server. The group is addressed similiar to a individual user: <groupname>@<server>. By default incoming and outgoing federated group shares are disabled in the admin settings.

send federated group share
individual user can accept share
individual user can decline share
individual user can unshare from self
handle unshare notification from owner correctly
handle permission change from owner correctly
UI to create federated group share

Fixes#4252

codecov · 2018-06-25T09:41:09Z

Codecov Report

Merging #9895 into master will decrease coverage by 45.08%.
The diff coverage is 1.44%.

@@ Coverage Diff @@## master #9895 +/- ##
============================================
- Coverage 51.4% 6.32% -45.09% - Complexity 26411 26448 +37 
============================================
Files 1690 1690 Lines 97712 97836 +124 Branches 1292 1290 -2 ============================================
- Hits 50233 6184 -44049 - Misses 47479 91652 +44173

Impacted Files	Coverage Δ	Complexity Δ
core/js/share.js	`44.55% <ø> (ø)`	`0 <0> (ø)`	⬇️
...dfilesharing/composer/composer/autoload_static.php	`0% <ø> (ø)`	`1 <0> (ø)`	⬇️
apps/cloud_federation_api/appinfo/app.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
apps/cloud_federation_api/lib/Capabilities.php	`0% <0%> (ø)`	`2 <2> (ø)`	⬇️
...es_sharing/lib/Controller/ShareesAPIController.php	`0% <0%> (-69.63%)`	`24 <2> (ø)`
...s/federatedfilesharing/lib/AppInfo/Application.php	`0% <0%> (-52.5%)`	`6 <1> (ø)`
...ation/Exceptions/AuthenticationFailedException.php	`0% <0%> (ø)`	`1 <1> (ø)`	⬇️
apps/cloud_federation_api/lib/Config.php	`0% <0%> (ø)`	`3 <3> (+1)`	⬆️
lib/private/Federation/CloudFederationShare.php	`0% <0%> (ø)`	`27 <27> (+2)`	⬆️
...lesharing/lib/ocm/CloudFederationProviderFiles.php	`0% <0%> (ø)`	`82 <82> (+8)`	⬆️
... and 950 more

MorrisJobke · 2018-07-03T21:15:07Z

@schiessle Could you rebase to resolve the conflicts and have less changes as the other PR got merged.

schiessle · 2018-07-04T08:22:37Z

@MorrisJobke just done 🙂

rullzer · 2018-07-05T09:57:29Z

I would feel a lot more comfortable if you could extend (or copy) the federated integration tests and move them to group shares. Just so we know when it does 💥

schiessle · 2018-07-10T12:13:30Z

@rullzer I added some integration tests. Now it is your turn 😉

rullzer · 2018-07-10T17:33:30Z

Now the unit tests fail ;)

rullzer · 2018-07-10T17:33:49Z

And yay for tests!

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle · 2018-07-11T08:22:20Z

@rullzer unit tests should be fixed now

MorrisJobke · 2018-07-11T14:47:21Z

Fixes #4252

I added this to the OP 😉

rullzer

Yay lets do this!

MorrisJobke

Code makes sense 👍

schiessle added 2. developing Work in progress feature: sharing feature: federation labels Jun 18, 2018

schiessle force-pushed the fed-group-shares branch from 589e17d to 037a610Compare June 25, 2018 09:41

schiessle force-pushed the fed-group-shares branch 2 times, most recently from 57beaba to a6430f6Compare June 29, 2018 10:02

MorrisJobke added this to the Nextcloud 14 milestone Jun 29, 2018

schiessle force-pushed the fed-group-shares branch from 013cf99 to 7a36964Compare July 3, 2018 16:44

schiessle force-pushed the fed-group-shares branch from 7a36964 to 4854965Compare July 4, 2018 08:21

schiessle added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 4, 2018

schiessle requested review from danxuliu, icewind1991 and rullzer July 4, 2018 11:14

schiessle mentioned this pull request Jul 5, 2018
share dialog doesn't show more then two exact matches? #10114
Closed

schiessle force-pushed the fed-group-shares branch 6 times, most recently from bac6cad to da020ebCompare July 10, 2018 12:11

schiessle added 2 commits July 11, 2018 10:11

add setting to enable/disable federated group sharing
c8631d6
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

implement federated group shares
b23032e
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle added 12 commits July 11, 2018 10:11

log error messgage
8bc0de3
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

translate nextcloud share types to OCM share types
4c00c80
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix notification when a group share is received
7a48a85
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

accept/decline group shares
f5a8162
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

unshare from self
7d2add6
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

handle unshare request from owner
1d5a9c3
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

start to get fed group shares into the share dialog
2abc705
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

update autoloader
5b06a7d
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

update unit tests
3942d73
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix js tests
f0aaf62
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

add some integration tests
0c09f56
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

fix unit tests
412f6a6
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle force-pushed the fed-group-shares branch from da020eb to 412f6a6Compare July 11, 2018 08:21

rullzer approved these changes Jul 11, 2018
View reviewed changes

MorrisJobke approved these changes Jul 11, 2018
View reviewed changes

MorrisJobke merged commit 3036b1d into masterJul 11, 2018

MorrisJobke deleted the fed-group-shares branch July 11, 2018 19:44

danxuliu mentioned this pull request Jul 12, 2018
Fix formatting of email and circle shares #10224
Merged

Navigation Menu

Uh oh!

Uh oh!

implement federated group sharing - #9895

implement federated group sharing#9895
MorrisJobke merged 14 commits into
masterfrom
fed-group-shares

schiessle commented Jun 18, 2018•
edited by MorrisJobke
Loading

Uh oh!

codecovBot commented Jun 25, 2018•
edited
Loading

Uh oh!

MorrisJobke commented Jul 3, 2018

Uh oh!

schiessle commented Jul 4, 2018

Uh oh!

rullzer commented Jul 5, 2018

Uh oh!

schiessle commented Jul 10, 2018•
edited
Loading

Uh oh!

rullzer commented Jul 10, 2018

Uh oh!

rullzer commented Jul 10, 2018

Uh oh!

schiessle commented Jul 11, 2018

Uh oh!

MorrisJobke commented Jul 11, 2018

Uh oh!

rullzer left a comment

Uh oh!

MorrisJobke left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

schiessle commented Jun 18, 2018• edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Jun 25, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MorrisJobke commented Jul 3, 2018

Uh oh!

schiessle commented Jul 4, 2018

Uh oh!

rullzer commented Jul 5, 2018

Uh oh!

schiessle commented Jul 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rullzer commented Jul 10, 2018

Uh oh!

rullzer commented Jul 10, 2018

Uh oh!

schiessle commented Jul 11, 2018

Uh oh!

MorrisJobke commented Jul 11, 2018

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

schiessle commented Jun 18, 2018•
edited by MorrisJobke
Loading

codecovBot commented Jun 25, 2018•
edited
Loading

schiessle commented Jul 10, 2018•
edited
Loading