Skip to content

Wait for load of script before binding - #28

Merged
MorrisJobke merged 2 commits into
nextcloud:masterfrom
rullzer:wait_for_load
Mar 25, 2019
Merged

Wait for load of script before binding#28
MorrisJobke merged 2 commits into
nextcloud:masterfrom
rullzer:wait_for_load

Conversation

@rullzer

@rullzerrullzer commented Mar 25, 2019

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Wait for load of script before binding
bf5f573
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Also move other drawSelf bind to onload
d4ee607
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
MorrisJobke approved these changes Mar 25, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
MorrisJobke merged commit 58aca24 into nextcloud:masterMar 25, 2019
@rullzer
rullzer deleted the wait_for_load branch March 25, 2019 09:56
@MorrisJobke

MorrisJobke commented Mar 25, 2019

Copy link
Copy Markdown
Member

Released as 0.5.8: https://github.com/MorrisJobke/strengthify/releases/tag/0.5.8

@ChristophWurstChristophWurst mentioned this pull request Mar 25, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@MorrisJobke