Uh oh!
There was an error while loading. Please reload this page.
Harden check when using token from memcache - #1014
Merged
Merged
Conversation
Explicitly comparing never hurt anybody. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
harden/memcachetokenfetching
branch
from
September 5, 2020 08:55
68ad904 to
57ab100Comparerullzer
commented
Sep 5, 2020
MemberAuthor
/backport to stable19 |
rullzer
commented
Sep 5, 2020
MemberAuthor
/backport to stable18 |
rullzer
commented
Sep 5, 2020
MemberAuthor
/backport to stable17 |
juliusknorr
approved these changes
Sep 7, 2020
The backport to stable18 failed. Please do this backport manually. |
The backport to stable17 failed. Please do this backport manually. |
juliusknorr
commented
Sep 7, 2020
Member
Session cache is only available starting with Nextcloud 19 #761 |
juliusknorr
commented
Sep 7, 2020
Member
@rullzer It might make sense to also backport that one, any opinions? |
MorrisJobke
commented
Dec 1, 2020
Member
🙄 |
juliusknorr
commented
Dec 22, 2020
Member
Not urgently needed, so I'd say we skip this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly comparing never hurt anybody.