Skip to content

IE11 madness - #1035

Merged
juliusknorr merged 8 commits into
stable18from
backport/stable18/1032
Sep 29, 2020
Merged

IE11 madness#1035
juliusknorr merged 8 commits into
stable18from
backport/stable18/1032

Conversation

@juliusknorr

Copy link
Copy Markdown
Member
  • Backport of Yet another IE11 fixing round #1032
  • Additionally downgrade core-js since for some reason this version causes issues with String.split with the regex that is used by prosemirror-model where "block+".split(/\s*(?=\b|\W|$)/) would return ["b", "l", "o", "c", "k", "+"] instead of ["block+"]
    However the exact same version combinations work fine on master, so I assume there are some wild polyfills overriding each other

Related issue for core-js zloirock/core-js#810

Otherwise we need to keep up with each dependency if it is actually IE11 compatible
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Sep 11, 2020
@juliusknorrjuliusknorr added this to the Nextcloud 18.0.10 milestone Sep 11, 2020
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Tests needs adjustments as well:

Error: Cannot find module '@babel/polyfill'
Require stack:
- /home/runner/work/text/text/src/tests/setup.js

@danxuliu

Copy link
Copy Markdown
Member

I can not add anything valuable, so I will just leave this here (and I can not believe that @skjnldsv has not done it yet):

this-is-madness-madness-this-is-ie11

@rullzerrullzer mentioned this pull request Sep 28, 2020
1 task
@rullzer

Copy link
Copy Markdown
Member

sooo 18.0.10? or...?

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Bump bundles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Yes, please.

Rebased and updated bundles

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Cypress failure currently expected

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@juliusknorr
juliusknorr merged commit ee84f45 into stable18Sep 29, 2020
@juliusknorr
juliusknorr deleted the backport/stable18/1032 branch September 29, 2020 09:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releasebugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@danxuliu@rullzer@skjnldsv