Skip to content

Simplify save indicator - #1353

Merged
juliusknorr merged 7 commits into
masterfrom
bugfix/1075/design
Feb 2, 2021
Merged

Simplify save indicator#1353
juliusknorr merged 7 commits into
masterfrom
bugfix/1075/design

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jan 14, 2021

Copy link
Copy Markdown
Member

Some fixes from the design review in #1075

Based on #1296

  • Simplify save indicator to Saving/Saved
  • Add some space to the menu bar so that button circles do no longer look cut off
  • Add disabled styling for undo/redo buttons Needed to revert this since it had a major performance impact and requires more investigation
  • Add improved indicator for active styling
  • Show full menubar on public share links (where the talk sidebar overlapped before)
  • Simplify wording
  • Add spacing to color annotations

Base automatically changed from enh/colors to masterJanuary 14, 2021 17:43
@juliusknorr
juliusknorr marked this pull request as ready for review January 26, 2021 07:54
@juliusknorrjuliusknorr added this to the Nextcloud 21 milestone Jan 26, 2021
@juliusknorr
juliusknorrforce-pushed the bugfix/1075/design branch 3 times, most recently from b8d757e to f6ac88dCompareJanuary 26, 2021 15:53
This was referenced Jan 27, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…ppening
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…es or not
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

cypress: default-group — 1 test failed

Failure from a previous run, but cypress doesn't update the state if the github action is just retriggered.

@rullzer

Copy link
Copy Markdown
Member

For me it shows all the way to the left. Is that intented?

2021-02-02_14-38

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as adverstied on regular md files.

@juliusknorr
juliusknorr merged commit 38e37b2 into masterFeb 2, 2021
@juliusknorr
juliusknorr deleted the bugfix/1075/design branch February 2, 2021 14:39
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Fix for that is in #1409

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@rullzer