Skip to content

Don't show "Link file" button when using direct edition - #1978

Merged
julien-nc merged 1 commit into
masterfrom
fix/1975/hide-link-file-if-direct-editing
Dec 2, 2021
Merged

Don't show "Link file" button when using direct edition#1978
julien-nc merged 1 commit into
masterfrom
fix/1975/hide-link-file-if-direct-editing

Conversation

@julien-nc

@julien-ncjulien-nc commented Dec 2, 2021

Copy link
Copy Markdown
Member

closes#1975
This uses the initial state to determine if we are using direct edition.

@julien-ncjulien-nc added this to the Nextcloud 24 milestone Dec 2, 2021
mejo-
mejo- approved these changes Dec 2, 2021
View reviewed changes

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise. I'm unable to test this easily.

juliusknorr
juliusknorr approved these changes Dec 2, 2021
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for taking care 👍

@juliusknorr

juliusknorr commented Dec 2, 2021

Copy link
Copy Markdown
Member

Looks good codewise. I'm unable to test this easily.

Just in case needed for the future, there are API examples expandable in the description of nextcloud/server#17625, but let me open an issue to move that to the documentation actually.

@juliusknorr

juliusknorr commented Dec 2, 2021

Copy link
Copy Markdown
Member

/rebase

@juliusknorr

juliusknorr commented Dec 2, 2021

Copy link
Copy Markdown
Member

Filed nextcloud/.github#28 to improve the rebase/compile automation as long as we have bundles committed.

@juliusknorr

juliusknorr commented Dec 2, 2021

Copy link
Copy Markdown
Member

/backport to stable23

@juliusknorr

juliusknorr commented Dec 2, 2021

Copy link
Copy Markdown
Member

/backport to stable22

Julien Veyssier
refs#1975don't show "Link file" button when using direct edition
3c561b1
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
julien-ncforce-pushed the fix/1975/hide-link-file-if-direct-editing branch from 4a10d33 to 3c561b1CompareDecember 2, 2021 14:13
@julien-nc

julien-nc commented Dec 2, 2021

Copy link
Copy Markdown
MemberAuthor

Filed nextcloud/.github#28 to improve the rebase/compile automation as long as we have bundles committed.

Nice to think we'll be able to avoid those long rebase with compiled assets 😁.

@julien-nc
julien-nc merged commit 6ed14bb into masterDec 2, 2021
@delete-merged-branch
delete-merged-branchBot deleted the fix/1975/hide-link-file-if-direct-editing branch December 2, 2021 14:43
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Dec 2, 2021
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Dec 2, 2021

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@julien-ncjulien-nc mentioned this pull request Dec 2, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@mejo-mejo-mejo- approved these changes

Assignees

No one assigned

Labels

3. to reviewbugSomething isn't workingformat: markdown

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

"Link file" button is displayed in Android client

3 participants

@julien-nc@juliusknorr@mejo-