Uh oh!
There was an error while loading. Please reload this page.
Use @nextcloud/logger for all frontend logging - #2866
Merged
Conversation
susnux
commented
Sep 6, 2022
ContributorAuthor
/compile amend |
nextcloud-commandforce-pushed
the
feat/logger
branch
from
September 6, 2022 13:23
2935df6 to
da4aae5Comparesusnux
commented
Sep 8, 2022
ContributorAuthor
/compile amend |
nextcloud-commandforce-pushed
the
feat/logger
branch
from
September 8, 2022 14:01
a2c8d3e to
7907481Comparemax-nextcloud
approved these changes
Sep 13, 2022
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
code looks good. Should not have any impact on behavior other than going through the @nextcloud/logger interface instead of console.*.
max-nextcloudforce-pushed
the
feat/logger
branch
2 times, most recently
from
September 13, 2022 10:29
86638b6 to
48c7ab8Comparemax-nextcloud
commented
Sep 13, 2022
Collaborator
/compile |
max-nextcloudforce-pushed
the
feat/logger
branch
from
September 13, 2022 10:55
48c7ab8 to
fbbf8cdComparemax-nextcloud
commented
Sep 13, 2022
Collaborator
/compile |
The nextcloud logger take account for the configured logging level, so only messages the user / administrator wants are logged. This fixes#2846 (no debug messages are logged if not configured). Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
max-nextcloudforce-pushed
the
feat/logger
branch
from
September 13, 2022 11:04
fbbf8cd to
81d7af7Comparemax-nextcloud
commented
Sep 13, 2022
Collaborator
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nextcloud logger take account for the configured logging level,
so only messages the user / administrator wants are logged.
This fixes#2846 (no debug messages are logged if not configured).