Uh oh!
There was an error while loading. Please reload this page.
fix: add primary attribute for current user - #2878
Merged
Merged
Conversation
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
The approach looks good.
ESLint has some complains as can be seen in the Files changed tab.
Other than that seems good to go.
Uh oh!
There was an error while loading. Please reload this page.
luka-nextcloudforce-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 12, 2022 17:00
1236681 to
a1d9461Compareluka-nextcloud
commented
Sep 12, 2022
ContributorAuthor
@max-nextcloud@vinicius73 Please check again. |
vinicius73
approved these changes
Sep 12, 2022
mejo-
commented
Sep 13, 2022
Member
/rebase |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
nextcloud-commandforce-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 07:29
a1d9461 to
640a1e1Comparemejo-
commented
Sep 13, 2022
Member
/compile |
mejo-force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 07:58
6a6c456 to
1b1b77aComparemejo-
commented
Sep 13, 2022
Member
I added a commit to fix the (unrelated) eslint warning introduced by #2867. |
Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 08:01
1b1b77a to
18a0598Comparemejo-
commented
Sep 13, 2022
Member
/compile amend |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
bug/use-primary-attr-for-current-user-mention
branch
from
September 13, 2022 08:05
18a0598 to
7f883b1Comparemejo-
approved these changes
Sep 13, 2022
delete-merged-branchBot
deleted the
bug/use-primary-attr-for-current-user-mention
branch
September 13, 2022 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary