Uh oh!
There was an error while loading. Please reload this page.
WIP: Test also CommonMark serialization - #3331
Closed
susnux wants to merge 2 commits into
Closed
Conversation
susnux
marked this pull request as draft
October 28, 2022 11:29
susnuxforce-pushed
the
feat/test-commonmark
branch
from
November 17, 2022 18:05
39037a7 to
3f8f45eCompareTest summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard | ||||||||||||||||||||||||||||||||||||||||||
As two different markdown strings can be semantically the same, we can test if the resulting rendered HTML are syntactically equal. Currently about hundred test cases fail because of a known limitation of `prosemirror-markdown` not able to serialize nested marks correctly, see ProseMirror/prosemirror-markdown#82 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
The commonmark parsing tests are already done by markdownit, as suche we only need to test serializing. And of cause parsing of markdown extensions we added. The current "CommonMark" testing also had quite a lot of hacks as even if we are commonmark compatible we do not yield the same html representation (html is only a interim stage to tiptap). Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
juliusknorrforce-pushed
the
feat/test-commonmark
branch
from
November 30, 2023 08:06
3f8f45e to
c804604Compare
This was referenced Mar 12, 2024
susnux
commented
Mar 14, 2024
ContributorAuthor
I do not think we need this anymore ❓ |
juliusknorr
commented
Apr 12, 2024
Member
I think we can revive when there is some more time to dive into the further markdown differences 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As two different markdown strings can be semantically the same, we can test if the resulting rendered HTML are syntactically equal.
Currently about hundred test cases fail because of a known limitation of
prosemirror-markdownnot able to serialize nested marks correctly, see ProseMirror/prosemirror-markdown#82So the CI test results can be used as a reference for identifiying problem for #2702 and also what needs to be fixed so that markdown files stay unchanged (#593)