Skip to content

Disable rich workspace rendering when view is not visible - #3349

Merged
juliusknorr merged 4 commits into
masterfrom
bugfix/noid/workspace-filelists
Nov 7, 2022
Merged

Disable rich workspace rendering when view is not visible#3349
juliusknorr merged 4 commits into
masterfrom
bugfix/noid/workspace-filelists

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Nov 2, 2022•
edited
Loading

Copy link
Copy Markdown
Member

As the file list is just hidden by the files app the vue component would still be active when switching to recent files for example.

@juliusknorr
juliusknorr requested review from azul, luka-nextcloud, max-nextcloud, mejo- and vinicius73 and removed request for azul and vinicius73November 2, 2022 12:45
@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Nov 2, 2022
@juliusknorr

juliusknorr commented Nov 2, 2022

Copy link
Copy Markdown
MemberAuthor

The event itself is available since 24 by the backports of nextcloud/server#34100

@juliusknorrjuliusknorr changed the title bugfix/noid/workspace filelistsDisable rich workspace rendering when view is not visibleNov 2, 2022
mejo-
mejo- reviewed Nov 2, 2022
View reviewed changes

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works well when tested locally. Cypress tests seem to need some love though.

@juliusknorr

juliusknorr commented Nov 2, 2022

Copy link
Copy Markdown
MemberAuthor

Strange, it was passing fine locally, but I'll dive into that.

@juliusknorr@max-nextcloud
Do not render the workspace if file list is hidden
5812336
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@max-nextcloud
Add cypress tests for switching views with rich workspaces
f85a3cd
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@max-nextcloud
max-nextcloudforce-pushed the bugfix/noid/workspace-filelists branch from 8b3b3d1 to f85a3cdCompareNovember 7, 2022 14:00
max-nextcloud
max-nextcloud requested changes Nov 7, 2022
View reviewed changes

@max-nextcloudmax-nextcloud left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Requesting some minor changes in tests that will make retries use consistent folder names.

They don't necessarily address the failures in CI though.

Comment threadcypress/e2e/workspace.spec.js Outdated
Comment threadcypress/e2e/workspace.spec.js Outdated
@cypress

cypressBot commented Nov 7, 2022•
edited
Loading

Copy link
Copy Markdown


Test summary

103 • 1 • 0 • 0 • Flakiness1

Run details

ProjectText
StatusFailed
Commitd5748e0ℹ️
StartedNov 7, 2022 3:13 PM
EndedNov 7, 2022 3:20 PM
Duration07:01 💡
OSLinux Ubuntu - 20.04
BrowserElectron 106

View run in Cypress Dashboard ➡️

Failures

cypress/e2e/links.spec.js 1 Failed
1 test link marks > link preview > shows a link preview

Flakiness

cypress/e2e/workspace.spec.js 1 Flakiness
1 Workspace > formats text

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

max-nextcloud
max-nextcloud reviewed Nov 7, 2022
View reviewed changes
Comment threadcypress/e2e/workspace.spec.js Outdated
@max-nextcloud
Fix minor issues in cypress tests leading to failures
9fed8ea
* `#workspace` is not found on the recent pages view at all - so need to combine selectors
* allow tests to pass in retries by using a consistent path name.
Signed-off-by: max-nextcloud <max@nextcloud.com>
mejo-
mejo- approved these changes Nov 7, 2022
View reviewed changes

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests @max-nextcloud.

@mejo-

mejo- commented Nov 7, 2022

Copy link
Copy Markdown
Member

/compile

@nextcloud-command
Compile assets
b48c03f
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-

mejo- commented Nov 7, 2022

Copy link
Copy Markdown
Member

/backport 5812336,f85a3cd5c996dbfe8d2230859d67ae5c17847242,9fed8ea72469d6d25c6723689aa5c2b634ea1a52 to stable25

@juliusknorr

juliusknorr commented Nov 7, 2022

Copy link
Copy Markdown
MemberAuthor

Failures/flaky tests are known, merging

@juliusknorr
juliusknorr merged commit 03cfafa into masterNov 7, 2022
@juliusknorr
juliusknorr deleted the bugfix/noid/workspace-filelists branch November 7, 2022 16:14
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Nov 7, 2022
Merged
1 task
@mejo-

mejo- commented Nov 7, 2022

Copy link
Copy Markdown
Member

backport 5812336,f85a3cd5c996dbfe8d2230859d67ae5c17847242,9fed8ea72469d6d25c6723689aa5c2b634ea1a52 to stable24

@mejo-

mejo- commented Nov 7, 2022

Copy link
Copy Markdown
Member

/backport 5812336,f85a3cd5c996dbfe8d2230859d67ae5c17847242,9fed8ea72469d6d25c6723689aa5c2b634ea1a52 to stable24

@backportbot-nextcloud

backportbot-nextcloudBot commented Nov 7, 2022

Copy link
Copy Markdown

The backport to stable24 failed. Please do this backport manually.

@juliusknorrjuliusknorr mentioned this pull request Nov 9, 2022
Merged
@blizzzblizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo-mejo-mejo- approved these changes
@max-nextcloudmax-nextcloudmax-nextcloud approved these changes
@luka-nextcloudluka-nextcloudAwaiting requested review from luka-nextcloud
@vinicius73vinicius73Awaiting requested review from vinicius73

Assignees

No one assigned

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable text app fetching if switching to other lists (Recents) Extend cypress tests

4 participants

@juliusknorr@mejo-@max-nextcloud@nextcloud-command