Uh oh!
There was an error while loading. Please reload this page.
Refactor Polling Backend and Sync service - #3799
Closed
max-nextcloud wants to merge 5 commits into
Closed
Conversation
max-nextcloudforce-pushed
the
refactor/polling
branch
from
February 16, 2023 20:44
e519140 to
2fefbe2Compare1 failed and 1 flaky tests on run #8658 ↗︎
Details:
| |||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| Open test.md in viewer > displays conflicts | Screenshot | |
cypress/e2e/share.spec.js • 1 flaky test
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error | Screenshot | |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Both were kept up to date but never used as far as i can tell. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
refactor/polling
branch
from
February 19, 2023 16:18
2fefbe2 to
e99556fCompareSave will only save the doc and doc state. Sync will only fetch steps from the server. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
refactor/polling
branch
from
February 20, 2023 06:48
e99556f to
742edb3Compare3 tasks
juliusknorr
commented
Jan 4, 2024
Member
@max-nextcloud Considering the amount of conflicts, is this something to rather do in smaller iterations? Can we extract some parts easily? Any plan to still continue or shall we close this for now? |
CollaboratorAuthor
Yes. It's basically 3 things:
My plan is to get one of these 3 parts ready for merge every week. This week I did 1. |
max-nextcloud
commented
Jun 23, 2025
CollaboratorAuthor
superseeded by #7311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Refactor the Polling Backend and Synchronization service
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)