Uh oh!
There was an error while loading. Please reload this page.
fix: Only handle recent awareness messagess from sessions - #4053
Merged
Conversation
juliusknorrforce-pushed
the
bugfix/noid/awareness-latest
branch
from
April 14, 2023 11:35
e9f4545 to
94e3b5eComparejuliusknorr
commented
Apr 14, 2023
MemberAuthor
/backport to stable26 |
1 flaky tests on run #9425 ↗︎
Details:
| |||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves on close | OutputScreenshots | |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloudforce-pushed
the
bugfix/noid/awareness-latest
branch
from
April 15, 2023 07:04
94e3b5e to
298f558Comparemax-nextcloud
approved these changes
Apr 15, 2023
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense to me. I'm wondering if we should only use the last awareness message but i need to dig into the awareness protocol more for that.
This is definitely a step in the right direction. So let's get it in.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
max-nextcloudforce-pushed
the
bugfix/noid/awareness-latest
branch
from
April 17, 2023 06:43
298f558 to
807b47fComparemax-nextcloud
commented
Apr 17, 2023
Collaborator
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#4010