Skip to content

Adjust smart picker menu action - #4063

Merged
max-nextcloud merged 3 commits into
mainfrom
enh/noid/smart-picker-menu-action-label
Apr 17, 2023
Merged

Adjust smart picker menu action#4063
max-nextcloud merged 3 commits into
mainfrom
enh/noid/smart-picker-menu-action-label

Conversation

@julien-nc

@julien-ncjulien-nc commented Apr 17, 2023

Copy link
Copy Markdown
Member
  • Adjust the menu item label
  • Adjust the icon to use the same as in Mail

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-ncjulien-nc added design Experience, interaction, interface, … 3. to review integration labels Apr 17, 2023
@julien-ncjulien-nc added this to the Nextcloud 27 milestone Apr 17, 2023
@julien-nc

Copy link
Copy Markdown
MemberAuthor

IMO this can be backported to stable26 but this is not a bug fix...

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
julien-ncforce-pushed the enh/noid/smart-picker-menu-action-label branch from 5750b9d to ded5e02CompareApril 17, 2023 10:49
@julien-nc

Copy link
Copy Markdown
MemberAuthor

/compile

@julien-ncjulien-nc changed the title Adjust smart picker menu action labelAdjust smart picker menu actionApr 17, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress

cypressBot commented Apr 17, 2023

Copy link
Copy Markdown

3 flaky tests on run #9429 ↗︎

014210Flakiness3

Details:

Adjust smart picker menu action
Project: TextCommit:53e89eb07b
Status: PassedDuration: 04:33 💡
Started: Apr 17, 2023 10:59 AMEnded: Apr 17, 2023 11:04 AM
Flakiness sync.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync > recovers from a lost connection OutputScreenshots
Flakiness conflict.spec.js • 2 flaky tests

ViewOutputVideo

Test Artifacts
Open test.md in viewer > resolves conflict using current editing session OutputScreenshots
Open test.md in viewer > resolves conflict using server version OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport to stable26

@max-nextcloud

Copy link
Copy Markdown
Collaborator

IMO this can be backported to stable26 but this is not a bug fix...

I'll create a backport request. Stable26 is blocked for most of the week anyway and we can discuss if we want to backport in the backport PR.

@max-nextcloud
max-nextcloud merged commit bb16978 into mainApr 17, 2023
@delete-merged-branch
delete-merged-branchBot deleted the enh/noid/smart-picker-menu-action-label branch April 17, 2023 18:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewdesignExperience, interaction, interface, …integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@julien-nc@max-nextcloud@nextcloud-command