Skip to content

Pass data to this.$parent.$emit in Editor.vue - #4102

Merged
mejo- merged 2 commits into
mainfrom
fix/editor_parent_emit_data
May 2, 2023
Merged

Pass data to this.$parent.$emit in Editor.vue#4102
mejo- merged 2 commits into
mainfrom
fix/editor_parent_emit_data

Conversation

@mejo-

@mejo-mejo- commented May 2, 2023

Copy link
Copy Markdown
Member

Fixes handling of attachment deletion in Collectives.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Fixes handling of attachment deletion in Collectives.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-

mejo- commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@mejo-

mejo- commented May 2, 2023

Copy link
Copy Markdown
MemberAuthor

/compile

@juliusknorrjuliusknorr added this to the Nextcloud 27 milestone May 2, 2023
@juliusknorrjuliusknorr added the bug Something isn't working label May 2, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress

cypressBot commented May 2, 2023

Copy link
Copy Markdown

2 failed and 1 flaky tests on run #9585 ↗︎

214010Flakiness1

Details:

Pass data to `this.$parent.$emit` in `Editor.vue`
Project: TextCommit:367741da8b
Status: FailedDuration: 04:41 💡
Started: May 2, 2023 11:44 AMEnded: May 2, 2023 11:49 AM
Failed workspace.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Workspace > callouts > toggle callouts OutputScreenshots
Failed sync.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Sync > recovers from a lost connection OutputScreenshots
Flakiness cypress/e2e/conflict.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Open test.md in viewer > resolves conflict using server version OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
mejo- merged commit e161c34 into mainMay 2, 2023
@delete-merged-branch
delete-merged-branchBot deleted the fix/editor_parent_emit_data branch May 2, 2023 11:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mejo-@juliusknorr@nextcloud-command