Uh oh!
There was an error while loading. Please reload this page.
Fix double readme files getting created on case-insensitive storages - #4104
Merged
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
commented
May 2, 2023
ContributorAuthor
/backport to stable26 |
szaimen
commented
May 2, 2023
ContributorAuthor
/backport to stable25 |
3 flaky tests on run #9590 ↗︎
Details:
| |||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Workspace > callouts > toggle callouts | OutputScreenshots | |
sync.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection | OutputScreenshots | |
share.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error | OutputScreenshots | |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloud
approved these changes
May 2, 2023
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! Thanks for the fix.
This was referenced May 2, 2023
juliusknorr
commented
May 2, 2023
Member
Thanks a lot for that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#3348
Apparently this got missing from #834 when the rebase was done.
See https://github.com/nextcloud/text/compare/1e600fb26111f0c850f134cf17aad96b1c8c59d3..7d6569cdf4c01e3467fe4b066a5f80bb56c48d9e
But actually @max-nextcloud and me tested a bit and this only seems to fix when creating new readme files from the workspace. The rootcase would probably need to be fixed somewhere in getFileInfo in View.php in server but we don't know much about that so adding this change here seems like a quick win.