Skip to content

[stable26] fix: pass file id for direct editing and fail y.js provider setup if none was passed - #4128

Merged
mejo- merged 2 commits into
stable26from
backport/4124/stable26
May 5, 2023
Merged

[stable26] fix: pass file id for direct editing and fail y.js provider setup if none was passed#4128
mejo- merged 2 commits into
stable26from
backport/4124/stable26

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented May 5, 2023

Copy link
Copy Markdown
  • ⚠️ This backport's changes differ from the original and might be incomplete

backport of #4124

…none was passed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@backportbot-nextcloudbackportbot-nextcloudBot added bug Something isn't working high labels May 5, 2023
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 26.0.2 milestone May 5, 2023
@mejo-

mejo- commented May 5, 2023

Copy link
Copy Markdown
Member

/compile

@cypress

cypressBot commented May 5, 2023

Copy link
Copy Markdown

1 flaky tests on run #9684 ↗︎

014210Flakiness1

Details:

[stable26] fix: pass file id for direct editing and fail y.js provider setup if ...
Project: TextCommit:bb444c9750
Status: PassedDuration: 04:08 💡
Started: May 5, 2023 4:39 PMEnded: May 5, 2023 4:43 PM
Flakiness cypress/e2e/share.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
mejo- merged commit 1a204e7 into stable26May 5, 2023
@delete-merged-branch
delete-merged-branchBot deleted the backport/4124/stable26 branch May 5, 2023 17:55
@blizzzblizzz mentioned this pull request May 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workinghigh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mejo-@juliusknorr@nextcloud-command