Skip to content

Fix/4267 js tests - #4268

Merged
max-nextcloud merged 2 commits into
mainfrom
fix/4267-js-tests
Jun 8, 2023
Merged

Fix/4267 js tests#4268
max-nextcloud merged 2 commits into
mainfrom
fix/4267-js-tests

Conversation

@max-nextcloud

@max-nextcloudmax-nextcloud commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentationis not required

@max-nextcloud
fix(tests): createEditor will not load content anymore
f1a6af7
These tests were failing since 25fd996.
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
fix(ci): add a jest workflow
34546a6
Make sure we actually run our js tests.
Signed-off-by: Max <max@nextcloud.com>
@juliusknorrjuliusknorr added tests If you write them we ♥ you 3. to review regression labels Jun 8, 2023
@juliusknorrjuliusknorr added this to the Nextcloud 28 milestone Jun 8, 2023
@cypress

cypressBot commented Jun 8, 2023

Copy link
Copy Markdown

Passing run #10090 ↗︎

014310Flakiness0

Details:

Fix/4267 js tests
Project: TextCommit:34546a6834
Status: PassedDuration: 03:37 💡
Started: Jun 8, 2023 4:25 PMEnded: Jun 8, 2023 4:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud

max-nextcloud commented Jun 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable27

@max-nextcloud

max-nextcloud commented Jun 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable26

@max-nextcloud
max-nextcloud merged commit b8b839a into mainJun 8, 2023
@delete-merged-branch
delete-merged-branchBot deleted the fix/4267-js-tests branch June 8, 2023 16:58
This was referenced Jun 8, 2023
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@mejo-mejo-Awaiting requested review from mejo-mejo- is a code owner

Assignees

No one assigned

Labels

3. to reviewregressiontestsIf you write them we ♥ you

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Fix js tests and bring them back to CI

2 participants

@max-nextcloud@juliusknorr