Skip to content

[stable27] fix: handle non markdown files in conflicts - #4272

Merged
max-nextcloud merged 5 commits into
stable27from
backport/4220/stable27
Aug 17, 2023
Merged

[stable27] fix: handle non markdown files in conflicts#4272
max-nextcloud merged 5 commits into
stable27from
backport/4220/stable27

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #4220

@cypress

cypressBot commented Jun 8, 2023

Copy link
Copy Markdown

6 failed and 1 flaky tests on run #11700 ↗︎

614220Flakiness1

Details:

[stable27] fix: handle non markdown files in conflicts
Project: TextCommit:0895c853a3
Status: FailedDuration: 05:48 💡
Started: Aug 17, 2023 7:00 AMEnded: Aug 17, 2023 7:06 AM
Failed workspace.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Workspace > relative folder links OutputScreenshots
Failed nodes/Links.spec.js • 3 failed tests

ViewOutputVideo

Test Artifacts
... > without text OutputScreenshots
... > with selected text OutputScreenshots
... > link to directory OutputScreenshots
Failed attachments.spec.js • 2 failed tests

ViewOutputVideo

Test Artifacts
Test all attachment insertion methods > Insert an image file from Files OutputScreenshots
Test all attachment insertion methods > test if attachment files are in the attachment folder OutputScreenshots
Flakiness cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync service provider > recovers from a dropped message OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzzblizzz mentioned this pull request Jun 12, 2023
@mejo-
mejo-force-pushed the backport/4220/stable27 branch from f18b8a2 to d515820CompareJune 19, 2023 14:27
@mejo-

Copy link
Copy Markdown
Member

@juliusknorr
juliusknorrforce-pushed the backport/4220/stable27 branch from d515820 to 0fed695CompareJune 19, 2023 19:26
@juliusknorrjuliusknorr added bug Something isn't working 25 feedback labels Jun 19, 2023
@juliusknorr

This comment was marked as outdated.

@juliusknorr

Copy link
Copy Markdown
Member

Hm, not sure what goes wrong there yet, also test seem fine on stable26 and main

@mejo-
mejo-force-pushed the backport/4220/stable27 branch from 0fed695 to 07599c2CompareJune 20, 2023 20:04
@juliusknorr
juliusknorrforce-pushed the backport/4220/stable27 branch from 07599c2 to f0efbc2CompareJune 22, 2023 21:16
@mejo-
mejo-force-pushed the backport/4220/stable27 branch from f0efbc2 to ee739bbCompareJune 27, 2023 06:13
@mejo-
mejo-force-pushed the backport/4220/stable27 branch from ee739bb to c0f9225CompareJuly 7, 2023 10:39
@blizzzblizzz mentioned this pull request Jul 10, 2023
@mejo-
mejo-force-pushed the backport/4220/stable27 branch from c0f9225 to 89997d8CompareJuly 21, 2023 09:20
@blizzzblizzz mentioned this pull request Aug 2, 2023
@blizzz
blizzzforce-pushed the backport/4220/stable27 branch from 89997d8 to 78e1c69CompareAugust 2, 2023 19:03
@blizzz

Copy link
Copy Markdown
Member

I think cypress is running with compiled assets.

@blizzz

Copy link
Copy Markdown
Member

moving to 27.1.0

@skjnldsvskjnldsv mentioned this pull request Aug 8, 2023
2 tasks
@skjnldsv

Copy link
Copy Markdown
Member

➡️ For beta 2

@skjnldsvskjnldsv mentioned this pull request Aug 16, 2023
7 tasks
@skjnldsv

Copy link
Copy Markdown
Member

Please merge or update milestone to 27.1.1

Do not parse non markdown files when resetting the content.
Fixes#4205.
Signed-off-by: Max <max@nextcloud.com>
Both the `.text-editor__main` and the `#read-only-editor`
are not part of the Editor component that the style is scoped for.
Signed-off-by: Max <max@nextcloud.com>
Text files are rendered as code blocks.
Do not apply the prosemirror style to keep the background color.
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud

Copy link
Copy Markdown
Collaborator

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud

Copy link
Copy Markdown
Collaborator

Same tests are failing on the main branch. They are due to changes in the file picker.

@max-nextcloud
max-nextcloud merged commit c0440c2 into stable27Aug 17, 2023
@max-nextcloud
max-nextcloud deleted the backport/4220/stable27 branch August 17, 2023 07:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing25 feedbackbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mejo-@juliusknorr@blizzz@skjnldsv@max-nextcloud@nextcloud-command