Skip to content

[stable26] fix: handle non markdown files in conflicts - #4273

Merged
mejo- merged 5 commits into
stable26from
backport/4220/stable26
Jun 8, 2023
Merged

[stable26] fix: handle non markdown files in conflicts#4273
mejo- merged 5 commits into
stable26from
backport/4220/stable26

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #4220

Do not parse non markdown files when resetting the content.
Fixes#4205.
Signed-off-by: Max <max@nextcloud.com>
Both the `.text-editor__main` and the `#read-only-editor`
are not part of the Editor component that the style is scoped for.
Signed-off-by: Max <max@nextcloud.com>
Text files are rendered as code blocks.
Do not apply the prosemirror style to keep the background color.
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
@cypress

cypressBot commented Jun 8, 2023

Copy link
Copy Markdown

2 flaky tests on run #10102 ↗︎

014610Flakiness2

Details:

[stable26] fix: handle non markdown files in conflicts
Project: TextCommit:a77bca7904
Status: PassedDuration: 04:48 💡
Started: Jun 8, 2023 8:31 PMEnded: Jun 8, 2023 8:36 PM
Flakiness sync.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync > recovers from a lost connection OutputScreenshots
Flakiness share.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-

mejo- commented Jun 8, 2023

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
mejo- merged commit 4a0d1d8 into stable26Jun 8, 2023
@delete-merged-branch
delete-merged-branchBot deleted the backport/4220/stable26 branch June 8, 2023 20:36
@blizzzblizzz mentioned this pull request Jun 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mejo-@max-nextcloud@nextcloud-command