Skip to content

fix(css): info callout box color to --color-info - #4301

Merged
max-nextcloud merged 2 commits into
mainfrom
fix/4161-info-callout-color
Jun 16, 2023
Merged

fix(css): info callout box color to --color-info#4301
max-nextcloud merged 2 commits into
mainfrom
fix/4161-info-callout-color

Conversation

@max-nextcloud

Copy link
Copy Markdown
Collaborator

📝 Summary

Fallback to the hard coded value for our primary element default. --color-info was only introduced with Nextcloud 27.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • no tests as we do not test css styles (yet).
  • Documentation is not required

Fallback to the hard coded value for our primary element default.
`--color-info` was only introduced with Nextcloud 27.
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud

Copy link
Copy Markdown
CollaboratorAuthor

/backport c564511 to stable27

@max-nextcloud

Copy link
Copy Markdown
CollaboratorAuthor

/backport c564511 to stable26

@max-nextcloud

Copy link
Copy Markdown
CollaboratorAuthor

/backport c564511 to stable25

@max-nextcloud

Copy link
Copy Markdown
CollaboratorAuthor

/compile

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress

cypressBot commented Jun 16, 2023

Copy link
Copy Markdown

2 failed and 1 flaky tests on run #10190 ↗︎

214213Flakiness1

Details:

fix(css): info callout box color to --color-info
Project: TextCommit:d8acca5e18
Status: FailedDuration: 03:44 💡
Started: Jun 16, 2023 6:03 PMEnded: Jun 16, 2023 6:07 PM
Failed sync.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Sync > recovers from a lost connection OutputScreenshots
Failed viewer.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Open test.md in viewer > See test.md in the list OutputScreenshots
Flakiness cypress/e2e/api/UsersApi.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
The user mention API > fetches users with valid session OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callout box with type info changes color with theme

3 participants

@max-nextcloud@mejo-@nextcloud-command